-
Notifications
You must be signed in to change notification settings - Fork 5.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
*: modify the printing of column default expression in SHOW CREATE TABLE
and Restore
#52940
*: modify the printing of column default expression in SHOW CREATE TABLE
and Restore
#52940
Conversation
Skipping CI for Draft Pull Request. |
Skipping CI for Draft Pull Request. |
SHOW CREATE TABLE
and Restore
/test all |
6ab0db4
to
a5ed48c
Compare
SHOW CREATE TABLE
and Restore
SHOW CREATE TABLE
and Restore
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #52940 +/- ##
=================================================
- Coverage 72.3753% 55.4486% -16.9268%
=================================================
Files 1481 1594 +113
Lines 428397 601663 +173266
=================================================
+ Hits 310054 333614 +23560
- Misses 99049 244825 +145776
- Partials 19294 23224 +3930
Flags with carried forward coverage won't be shown. Click here to find out more.
|
/retest |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
a5ed48c
to
e94c799
Compare
/retest |
/retest |
/approve |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: easonn7, tangenta, zimulala The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/retest |
/retest-required |
In response to a cherrypick label: new pull request created to branch |
Signed-off-by: ti-chi-bot <ti-community-prow-bot@tidb.io>
In response to a cherrypick label: new pull request created to branch |
Signed-off-by: ti-chi-bot <ti-community-prow-bot@tidb.io>
Signed-off-by: ti-chi-bot <ti-community-prow-bot@tidb.io>
In response to a cherrypick label: new pull request created to branch |
Signed-off-by: ti-chi-bot <ti-community-prow-bot@tidb.io>
In response to a cherrypick label: new pull request created to branch |
In response to a cherrypick label: new pull request created to branch |
What problem does this PR solve?
Issue Number: close #52939
Problem Summary:
See the description of the issue.
What changed and how does it work?
If the column default expression is
ast.FuncCallExpr
exceptast.CurrentTimestamp
, wrap an outer parentheses inSHOW CREATE TABLE
andRestore()
Check List
Tests
Side effects
Documentation
Release note
Please refer to Release Notes Language Style Guide to write a quality release note.