br/operator: fix adapt env for snapshot backup stuck when encountered error (#52607) #52969
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: hillium <yu745514916@live.com>
Signed-off-by: hillium <yu745514916@live.com>
Signed-off-by: hillium <yujuncen@pingcap.com>
Co-authored-by: BornChanger <97348524+BornChanger@users.noreply.github.com>
ti-chi-bot
added
the
release-note-none
12 tasks
ti-chi-bot
added
size/M
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## release-6.5 #52969 +/- ##
================================================
Coverage ? 73.6439%
================================================
Files ? 1096
Lines ? 351581
Branches ? 0
================================================
Hits ? 258918
Misses ? 76014
Partials ? 16649 |
BornChanger
approved these changes
May 6, 2024
YuJuncen
approved these changes
May 6, 2024
ti-chi-bot
added
the
cherry-pick-approved
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: BornChanger, YuJuncen The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
ti-chi-bot
bot
added
lgtm
approved
and removed
do-not-merge/cherry-pick-not-approved
needs-1-more-lgtm
[LGTM Timeline notifier]Timeline:
|
mittalrishabh
pushed a commit
to mittalrishabh/tidb
that referenced
this pull request
May 30, 2024
… error (pingcap#52607) (pingcap#52969) (pingcap#88) close pingcap#52846 Co-authored-by: Ti Chi Robot <ti-community-prow-bot@tidb.io>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is an automated cherry-pick of #52607
What problem does this PR solve?
Issue Number: close #52846
Problem Summary:
When we failed to prepare the connections for wait apply, the channel may never be closed. Hence the pause PD operation (which relies on the finishing of the prepare connections stage) get stuck.
What changed and how does it work?
Selected over the context so it can be canceled.
Check List
Tests
Side effects
Documentation
Release note
Please refer to Release Notes Language Style Guide to write a quality release note.