-
Notifications
You must be signed in to change notification settings - Fork 5.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
*: check delete unique key's handle to handle corner case #52975
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #52975 +/- ##
================================================
+ Coverage 74.4290% 74.4937% +0.0647%
================================================
Files 1497 1518 +21
Lines 356920 447126 +90206
================================================
+ Hits 265652 333081 +67429
- Misses 71938 93644 +21706
- Partials 19330 20401 +1071
Flags with carried forward coverage won't be shown. Click here to find out more.
|
/retest |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: Benjamin2037, tangenta The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
[LGTM Timeline notifier]Timeline:
|
/retest |
In response to a cherrypick label: new pull request created to branch |
Signed-off-by: ti-chi-bot <ti-community-prow-bot@tidb.io>
In response to a cherrypick label: new pull request created to branch |
Signed-off-by: ti-chi-bot <ti-community-prow-bot@tidb.io>
In response to a cherrypick label: new pull request created to branch |
Signed-off-by: ti-chi-bot <ti-community-prow-bot@tidb.io>
Signed-off-by: ti-chi-bot <ti-community-prow-bot@tidb.io>
In response to a cherrypick label: new pull request created to branch |
What problem does this PR solve?
Issue Number: close #52914
Problem Summary:
Take the case from the issue, if an insert is executed during delete only, there is no record on the temporary index.
Before the merge process, a delete operation may delete the index key value(generated by ingest) unexpectedly.
To avoid this problem, we need to check if the delete value's handle is the same as we want to delete.
If not, it means that the value we want to delete is covered by another value already, which shouldn't be deleted again.
What changed and how does it work?
Check List
Tests
Side effects
Documentation
Release note
Please refer to Release Notes Language Style Guide to write a quality release note.