Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

executor: handle the corner case that temp index is not exist but the normal index is exist (#51862) #53066

Merged

Conversation

ti-chi-bot
Copy link
Member

This is an automated cherry-pick of #51862

What problem does this PR solve?

Issue Number: close #51784

Problem Summary:
If the temp index is not exist, we need to check if the normal index is exist.
The corner case is showed in the added unit test.

What changed and how does it work?

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No need to test
    • I checked and no code files have been changed.

Side effects

  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Breaking backward compatibility

Documentation

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Changes MySQL compatibility

Release note

Please refer to Release Notes Language Style Guide to write a quality release note.

fix a bug may cause unique index and data inconsistent when using insert ignore

Signed-off-by: ti-chi-bot <ti-community-prow-bot@tidb.io>
@ti-chi-bot ti-chi-bot added release-note Denotes a PR that will be considered when it comes time to generate release notes. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. type/cherry-pick-for-release-7.5 This PR is cherry-picked to release-7.5 from a source PR. labels May 7, 2024
@ti-chi-bot ti-chi-bot added the cherry-pick-approved Cherry pick PR approved by release team. label May 7, 2024
Copy link

codecov bot commented May 27, 2024

Codecov Report

Attention: Patch coverage is 60.00000% with 16 lines in your changes are missing coverage. Please review.

Please upload report for BASE (release-7.5@1e19051). Learn more about missing BASE report.

Additional details and impacted files
@@               Coverage Diff                @@
##             release-7.5     #53066   +/-   ##
================================================
  Coverage               ?   71.9953%           
================================================
  Files                  ?       1411           
  Lines                  ?     410364           
  Branches               ?          0           
================================================
  Hits                   ?     295443           
  Misses                 ?      95043           
  Partials               ?      19878           
Flag Coverage Δ
unit 71.9953% <60.0000%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
dumpling 53.9913% <0.0000%> (?)
parser ∅ <0.0000%> (?)
br 53.4420% <0.0000%> (?)

@ti-chi-bot ti-chi-bot bot added approved needs-1-more-lgtm Indicates a PR needs 1 more LGTM. labels May 27, 2024
Copy link

ti-chi-bot bot commented May 27, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: tangenta, zimulala

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot bot added lgtm and removed needs-1-more-lgtm Indicates a PR needs 1 more LGTM. labels May 27, 2024
Copy link

ti-chi-bot bot commented May 27, 2024

[LGTM Timeline notifier]

Timeline:

  • 2024-05-27 09:51:53.353266904 +0000 UTC m=+2683667.110402470: ☑️ agreed by tangenta.
  • 2024-05-27 09:52:34.853908913 +0000 UTC m=+2683708.611044481: ☑️ agreed by zimulala.

@ti-chi-bot ti-chi-bot bot merged commit 4ee2b86 into pingcap:release-7.5 May 27, 2024
16 of 18 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved cherry-pick-approved Cherry pick PR approved by release team. lgtm release-note Denotes a PR that will be considered when it comes time to generate release notes. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. type/cherry-pick-for-release-7.5 This PR is cherry-picked to release-7.5 from a source PR.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants