Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

*: fix 'Duplicate entry' error when @@auto_increment_increment and @@auto_increment_offset is set (#52626) #53115

Merged

Conversation

ti-chi-bot
Copy link
Member

This is an automated cherry-pick of #52626

What problem does this PR solve?

Issue Number: close #52622

Problem Summary:

What changed and how does it work?

  1. set auto_increment_offset to 1 if its value is greater than auto_increment_increment
  2. add more check to protect alloc.base from been change to a smaller value

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)

Follow the steps in the issue

  • No need to test
    • I checked and no code files have been changed.

Side effects

  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Breaking backward compatibility

Documentation

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Changes MySQL compatibility

Release note

Please refer to Release Notes Language Style Guide to write a quality release note.

None

@ti-chi-bot ti-chi-bot added release-note-none Denotes a PR that doesn't merit a release note. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. type/cherry-pick-for-release-8.1 This PR is cherry-picked to release-8.1 from a source PR. labels May 9, 2024
@tiancaiamao tiancaiamao requested review from bb7133 and Defined2014 May 9, 2024 01:32
@tiancaiamao
Copy link
Contributor

/retest-required

Copy link

codecov bot commented May 9, 2024

Codecov Report

Attention: Patch coverage is 94.73684% with 1 lines in your changes are missing coverage. Please review.

❗ No coverage uploaded for pull request base (release-8.1@238f2e6). Click here to learn what that means.

Additional details and impacted files
@@               Coverage Diff                @@
##             release-8.1     #53115   +/-   ##
================================================
  Coverage               ?   71.1449%           
================================================
  Files                  ?       1463           
  Lines                  ?     420682           
  Branches               ?          0           
================================================
  Hits                   ?     299294           
  Misses                 ?     100917           
  Partials               ?      20471           
Flag Coverage Δ
unit 71.1449% <94.7368%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
dumpling 53.9957% <0.0000%> (?)
parser ∅ <0.0000%> (?)
br 40.9617% <0.0000%> (?)

@ti-chi-bot ti-chi-bot added the cherry-pick-approved Cherry pick PR approved by release team. label May 9, 2024
@ti-chi-bot ti-chi-bot bot added the needs-1-more-lgtm Indicates a PR needs 1 more LGTM. label May 9, 2024
@ti-chi-bot ti-chi-bot bot added lgtm and removed needs-1-more-lgtm Indicates a PR needs 1 more LGTM. labels May 9, 2024
Copy link

ti-chi-bot bot commented May 9, 2024

[LGTM Timeline notifier]

Timeline:

  • 2024-05-09 07:53:03.122498859 +0000 UTC m=+1121336.879634428: ☑️ agreed by Defined2014.
  • 2024-05-09 07:53:31.066927133 +0000 UTC m=+1121364.824062706: ☑️ agreed by tiancaiamao.

Copy link

ti-chi-bot bot commented May 9, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: Defined2014, tiancaiamao, zimulala

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot bot added the approved label May 9, 2024
@ti-chi-bot ti-chi-bot bot merged commit ad8a94a into pingcap:release-8.1 May 9, 2024
18 checks passed
@wuhuizuo wuhuizuo deleted the cherry-pick-52626-to-release-8.1 branch May 10, 2024 02:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved cherry-pick-approved Cherry pick PR approved by release team. lgtm release-note-none Denotes a PR that doesn't merit a release note. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. type/cherry-pick-for-release-8.1 This PR is cherry-picked to release-8.1 from a source PR.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants