Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

planner: UPDATE's select plan's output col IDs should be stable #53268

Merged
merged 5 commits into from
May 14, 2024

Conversation

winoros
Copy link
Member

@winoros winoros commented May 14, 2024

What problem does this PR solve?

Issue Number: close #53236

Problem Summary:

The output UniqueIDs in the UPDATE's SELECT plan should remain unchanged after the optimization.

What changed and how does it work?

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No need to test
    • I checked and no code files have been changed.

Side effects

  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Breaking backward compatibility

Documentation

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Changes MySQL compatibility

Release note

Please refer to Release Notes Language Style Guide to write a quality release note.

None

@ti-chi-bot ti-chi-bot bot added release-note-none Denotes a PR that doesn't merit a release note. do-not-merge/needs-triage-completed sig/planner SIG: Planner size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed do-not-merge/needs-triage-completed labels May 14, 2024
@ti-chi-bot ti-chi-bot bot added the needs-1-more-lgtm Indicates a PR needs 1 more LGTM. label May 14, 2024
@winoros winoros changed the title planner: UPDATE's select plan's output should be stable planner: UPDATE's select plan's output col IDs should be stable May 14, 2024
Copy link

codecov bot commented May 14, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 74.4891%. Comparing base (045a5b5) to head (13db18e).

Additional details and impacted files
@@               Coverage Diff                @@
##             master     #53268        +/-   ##
================================================
+ Coverage   72.4499%   74.4891%   +2.0391%     
================================================
  Files          1493       1493                
  Lines        429360     429397        +37     
================================================
+ Hits         311071     319854      +8783     
+ Misses        99017      89659      -9358     
- Partials      19272      19884       +612     
Flag Coverage Δ
integration 49.0028% <100.0000%> (?)
unit 71.2466% <70.0000%> (-0.0959%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
dumpling 53.9957% <ø> (ø)
parser ∅ <ø> (∅)
br 50.1840% <ø> (+8.7571%) ⬆️

@ti-chi-bot ti-chi-bot bot added lgtm and removed needs-1-more-lgtm Indicates a PR needs 1 more LGTM. labels May 14, 2024
Copy link

ti-chi-bot bot commented May 14, 2024

[LGTM Timeline notifier]

Timeline:

  • 2024-05-14 12:17:29.899304445 +0000 UTC m=+1569203.656440018: ☑️ agreed by AilinKid.
  • 2024-05-14 12:53:10.854704787 +0000 UTC m=+1571344.611840360: ☑️ agreed by time-and-fate.

@ti-chi-bot ti-chi-bot bot added the approved label May 14, 2024
@ti-chi-bot ti-chi-bot bot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels May 14, 2024
Copy link

ti-chi-bot bot commented May 14, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: AilinKid, time-and-fate, XuHuaiyu

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot bot merged commit acdb6f5 into pingcap:master May 14, 2024
23 checks passed
@winoros
Copy link
Member Author

winoros commented May 14, 2024

/cherrypick release-8.1

@winoros winoros deleted the issue53236 branch May 14, 2024 14:19
@ti-chi-bot
Copy link
Member

@winoros: new pull request created to branch release-8.1: #53273.

In response to this:

/cherrypick release-8.1

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

@ti-chi-bot ti-chi-bot added the needs-cherry-pick-release-7.5 Should cherry pick this PR to release-7.5 branch. label May 14, 2024
@ti-chi-bot ti-chi-bot added needs-cherry-pick-release-7.1 Should cherry pick this PR to release-7.1 branch. needs-cherry-pick-release-6.5 Should cherry pick this PR to release-6.5 branch. labels May 14, 2024
@ti-chi-bot
Copy link
Member

In response to a cherrypick label: new pull request created to branch release-7.5: #53274.

ti-chi-bot pushed a commit to ti-chi-bot/tidb that referenced this pull request May 14, 2024
Signed-off-by: ti-chi-bot <ti-community-prow-bot@tidb.io>
@ti-chi-bot
Copy link
Member

In response to a cherrypick label: new pull request created to branch release-7.1: #53275.

ti-chi-bot pushed a commit to ti-chi-bot/tidb that referenced this pull request May 14, 2024
Signed-off-by: ti-chi-bot <ti-community-prow-bot@tidb.io>
@ti-chi-bot
Copy link
Member

In response to a cherrypick label: new pull request created to branch release-6.5: #53276.

ti-chi-bot pushed a commit to ti-chi-bot/tidb that referenced this pull request May 14, 2024
Signed-off-by: ti-chi-bot <ti-community-prow-bot@tidb.io>
@@ -178,7 +178,6 @@ nogo(
}) +
select({
"//build:without_rbe": [
"//build/linter/filepermission",
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

?

winoros added a commit to ti-chi-bot/tidb that referenced this pull request Nov 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved lgtm needs-cherry-pick-release-6.5 Should cherry pick this PR to release-6.5 branch. needs-cherry-pick-release-7.1 Should cherry pick this PR to release-7.1 branch. needs-cherry-pick-release-7.5 Should cherry pick this PR to release-7.5 branch. release-note-none Denotes a PR that doesn't merit a release note. sig/planner SIG: Planner size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Failed to execute SQL, but succeed in mysql:v8.0
6 participants