-
Notifications
You must be signed in to change notification settings - Fork 5.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
statistics: fix wrong behavior for primary key' non-lite init stats #53298
Conversation
Signed-off-by: Weizhen Wang <wangweizhen@pingcap.com>
26a5cd8
to
629752b
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #53298 +/- ##
================================================
+ Coverage 72.4355% 74.6278% +2.1922%
================================================
Files 1494 1497 +3
Lines 429347 432711 +3364
================================================
+ Hits 311000 322923 +11923
+ Misses 99066 89600 -9466
- Partials 19281 20188 +907
Flags with carried forward coverage won't be shown. Click here to find out more.
|
Signed-off-by: Weizhen Wang <wangweizhen@pingcap.com>
Signed-off-by: Weizhen Wang <wangweizhen@pingcap.com>
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: qw4990, winoros The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Signed-off-by: Weizhen Wang <wangweizhen@pingcap.com>
/cherrypick release-8.1 |
@hawkingrei: new pull request created to branch In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository. |
Signed-off-by: ti-chi-bot <ti-community-prow-bot@tidb.io>
In response to a cherrypick label: new pull request created to branch |
Signed-off-by: ti-chi-bot <ti-community-prow-bot@tidb.io>
In response to a cherrypick label: new pull request created to branch |
Signed-off-by: ti-chi-bot <ti-community-prow-bot@tidb.io>
Signed-off-by: ti-chi-bot <ti-community-prow-bot@tidb.io>
Signed-off-by: ti-chi-bot <ti-community-prow-bot@tidb.io>
In response to a cherrypick label: new pull request created to branch |
What problem does this PR solve?
Issue Number: ref #37548
Problem Summary:
What changed and how does it work?
primary key's is_index is false. so it cannot load the topn. it's stats cannon be set as
AllFull
.Check List
Tests
according to #37548, it's result is right.
Side effects
Documentation
Release note
Please refer to Release Notes Language Style Guide to write a quality release note.