Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

statistics: fix wrong behavior for primary key' non-lite init stats #53298

Merged
merged 4 commits into from
May 15, 2024

Conversation

hawkingrei
Copy link
Member

@hawkingrei hawkingrei commented May 15, 2024

What problem does this PR solve?

Issue Number: ref #37548

Problem Summary:

What changed and how does it work?

primary key's is_index is false. so it cannot load the topn. it's stats cannon be set as AllFull.

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)

according to #37548, it's result is right.

  • No need to test
    • I checked and no code files have been changed.

Side effects

  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Breaking backward compatibility

Documentation

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Changes MySQL compatibility

Release note

Please refer to Release Notes Language Style Guide to write a quality release note.

None

@ti-chi-bot ti-chi-bot bot added do-not-merge/needs-linked-issue do-not-merge/needs-tests-checked release-note-none Denotes a PR that doesn't merit a release note. sig/planner SIG: Planner size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels May 15, 2024
Signed-off-by: Weizhen Wang <wangweizhen@pingcap.com>
@ti-chi-bot ti-chi-bot bot added size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. and removed size/M Denotes a PR that changes 30-99 lines, ignoring generated files. do-not-merge/needs-tests-checked labels May 15, 2024
Copy link

codecov bot commented May 15, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 74.6278%. Comparing base (76133dc) to head (c9fbfa5).
Report is 888 commits behind head on master.

Additional details and impacted files
@@               Coverage Diff                @@
##             master     #53298        +/-   ##
================================================
+ Coverage   72.4355%   74.6278%   +2.1922%     
================================================
  Files          1494       1497         +3     
  Lines        429347     432711      +3364     
================================================
+ Hits         311000     322923     +11923     
+ Misses        99066      89600      -9466     
- Partials      19281      20188       +907     
Flag Coverage Δ
integration 49.0713% <0.0000%> (?)
unit 71.2915% <100.0000%> (-1.1427%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
dumpling 53.9957% <ø> (ø)
parser ∅ <ø> (∅)
br 50.1896% <ø> (+8.7594%) ⬆️

Signed-off-by: Weizhen Wang <wangweizhen@pingcap.com>
@ti-chi-bot ti-chi-bot bot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. and removed size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. do-not-merge/needs-linked-issue labels May 15, 2024
Signed-off-by: Weizhen Wang <wangweizhen@pingcap.com>
@ti-chi-bot ti-chi-bot bot added approved needs-1-more-lgtm Indicates a PR needs 1 more LGTM. labels May 15, 2024
@hawkingrei hawkingrei changed the title statistics: fix wrong behavior for primary key' init stats statistics: fix wrong behavior for primary key' non-lite init stats May 15, 2024
Copy link

ti-chi-bot bot commented May 15, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: qw4990, winoros

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot bot added lgtm and removed needs-1-more-lgtm Indicates a PR needs 1 more LGTM. labels May 15, 2024
Copy link

ti-chi-bot bot commented May 15, 2024

[LGTM Timeline notifier]

Timeline:

  • 2024-05-15 11:08:39.159820742 +0000 UTC m=+1651472.916956314: ☑️ agreed by winoros.
  • 2024-05-15 12:23:57.934478283 +0000 UTC m=+1655991.691613853: ☑️ agreed by qw4990.

Signed-off-by: Weizhen Wang <wangweizhen@pingcap.com>
@ti-chi-bot ti-chi-bot bot merged commit 687f39c into pingcap:master May 15, 2024
22 of 23 checks passed
@hawkingrei
Copy link
Member Author

/cherrypick release-8.1

@hawkingrei hawkingrei deleted the fix_missing_0515 branch May 15, 2024 15:31
@ti-chi-bot
Copy link
Member

@hawkingrei: new pull request created to branch release-8.1: #53304.

In response to this:

/cherrypick release-8.1

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

@ti-chi-bot
Copy link
Member

In response to a cherrypick label: new pull request created to branch release-6.5: #53710.

hawkingrei added a commit to ti-chi-bot/tidb that referenced this pull request Jun 6, 2024
Signed-off-by: ti-chi-bot <ti-community-prow-bot@tidb.io>
@ti-chi-bot ti-chi-bot added the needs-cherry-pick-release-7.1 Should cherry pick this PR to release-7.1 branch. label Jun 25, 2024
@ti-chi-bot
Copy link
Member

In response to a cherrypick label: new pull request created to branch release-7.1: #54204.

ti-chi-bot pushed a commit to ti-chi-bot/tidb that referenced this pull request Jun 25, 2024
Signed-off-by: ti-chi-bot <ti-community-prow-bot@tidb.io>
hawkingrei added a commit to ti-chi-bot/tidb that referenced this pull request Aug 29, 2024
Signed-off-by: ti-chi-bot <ti-community-prow-bot@tidb.io>
@ti-chi-bot ti-chi-bot bot added the needs-cherry-pick-release-6.1 Should cherry pick this PR to release-6.1 branch. label Sep 11, 2024
ti-chi-bot pushed a commit to ti-chi-bot/tidb that referenced this pull request Sep 11, 2024
Signed-off-by: ti-chi-bot <ti-community-prow-bot@tidb.io>
@ti-chi-bot
Copy link
Member

In response to a cherrypick label: new pull request created to branch release-6.1: #56011.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved lgtm needs-cherry-pick-release-6.1 Should cherry pick this PR to release-6.1 branch. needs-cherry-pick-release-6.5 Should cherry pick this PR to release-6.5 branch. needs-cherry-pick-release-7.1 Should cherry pick this PR to release-7.1 branch. release-note-none Denotes a PR that doesn't merit a release note. sig/planner SIG: Planner size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants