Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

planner: column pruning should use a shallow copy slice (#53237) #53322

Merged
merged 2 commits into from
Jun 9, 2024
Merged

planner: column pruning should use a shallow copy slice (#53237) #53322

merged 2 commits into from
Jun 9, 2024

Conversation

ti-chi-bot
Copy link
Member

This is an automated cherry-pick of #53237

What problem does this PR solve?

Issue Number: close #52768

Problem Summary:

What changed and how does it work?

The slice passed to the column pruning should be shallow copied.

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No need to test
    • I checked and no code files have been changed.

Side effects

  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Breaking backward compatibility

Documentation

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Changes MySQL compatibility

Release note

Please refer to Release Notes Language Style Guide to write a quality release note.

None

@ti-chi-bot ti-chi-bot added release-note-none Denotes a PR that doesn't merit a release note. sig/planner SIG: Planner size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. type/cherry-pick-for-release-6.5 This PR is cherry-picked to release-6.5 from a source PR. labels May 16, 2024
@ti-chi-bot ti-chi-bot mentioned this pull request May 16, 2024
Merged
13 tasks
@ti-chi-bot ti-chi-bot bot added do-not-merge/cherry-pick-not-approved size/S Denotes a PR that changes 10-29 lines, ignoring generated files. and removed size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels May 16, 2024
@ti-chi-bot ti-chi-bot added the cherry-pick-approved Cherry pick PR approved by release team. label Jun 4, 2024
@Rustin170506
fix conflict
4713bdc 
Signed-off-by: hi-rustin <rustin.liu@gmail.com>
@Rustin170506 Rustin170506 force-pushed the cherry-pick-53237-to-release-6.5 branch from 2fb8b57 to 4713bdc Compare June 8, 2024 08:49
@ti-chi-bot ti-chi-bot bot added size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. and removed size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Jun 8, 2024
@ti-chi-bot ti-chi-bot bot added needs-1-more-lgtm Indicates a PR needs 1 more LGTM. approved labels Jun 8, 2024
@Rustin170506
fix
e976519 
Signed-off-by: hi-rustin <rustin.liu@gmail.com>
@codecov Codecov
Copy link

codecov bot commented Jun 8, 2024 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Please upload report for BASE (release-6.5@5722930). Learn more about missing BASE report.

Additional details and impacted files 
@@               Coverage Diff                @@
##             release-6.5     #53322   +/-   ##
================================================
  Coverage               ?   73.6485%           
================================================
  Files                  ?       1096           
  Lines                  ?     352034           
  Branches               ?          0           
================================================
  Hits                   ?     259268           
  Misses                 ?      76111           
  Partials               ?      16655

fixdb
fixdb approved these changes Jun 9, 2024
View reviewed changes
Copy link
Contributor

@fixdb fixdb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1

@ti-chi-bot ti-chi-bot bot added the lgtm label Jun 9, 2024
@ti-chi-bot ti-chi-bot
Copy link

ti-chi-bot bot commented Jun 9, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: fixdb, hi-rustin

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot bot removed the needs-1-more-lgtm Indicates a PR needs 1 more LGTM. label Jun 9, 2024
@ti-chi-bot ti-chi-bot
Copy link

ti-chi-bot bot commented Jun 9, 2024

[LGTM Timeline notifier]

Timeline:

  • 2024-06-08 08:49:32.45813458 +0000 UTC m=+195326.511446507: ☑️ agreed by hi-rustin.
  • 2024-06-09 21:04:46.933465408 +0000 UTC m=+325840.986777333: ☑️ agreed by fixdb.

@ti-chi-bot ti-chi-bot bot merged commit a03d354 into pingcap:release-6.5 Jun 9, 2024
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Rustin170506 Rustin170506 Rustin170506 approved these changes

@fixdb fixdb fixdb approved these changes

Assignees

@winoros winoros

Labels
approved cherry-pick-approved Cherry pick PR approved by release team. lgtm release-note-none Denotes a PR that doesn't merit a release note. sig/planner SIG: Planner size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. type/cherry-pick-for-release-6.5 This PR is cherry-picked to release-6.5 from a source PR.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@ti-chi-bot @fixdb @Rustin170506 @winoros