-
Notifications
You must be signed in to change notification settings - Fork 5.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
context: Add method to detach the tableReaderExecutor
from the session context
#53337
Conversation
Skipping CI for Draft Pull Request. |
/retest |
Skipping CI for Draft Pull Request. |
82d36eb
to
cec996c
Compare
/retest |
cec996c
to
c106156
Compare
/retest |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #53337 +/- ##
================================================
+ Coverage 74.4310% 74.6350% +0.2040%
================================================
Files 1506 1506
Lines 358004 429972 +71968
================================================
+ Hits 266466 320910 +54444
- Misses 72097 89222 +17125
- Partials 19441 19840 +399
Flags with carried forward coverage won't be shown. Click here to find out more.
|
c106156
to
52933d6
Compare
/retest |
52933d6
to
740ccd3
Compare
/retest |
@YangKeao: The following test failed, say
Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
@YangKeao: The following test failed, say
Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
Signed-off-by: Yang Keao <yangkeao@chunibyo.icu>
740ccd3
to
f46794f
Compare
[FORMAT CHECKER NOTIFICATION] Notice: To remove the For example:
📖 For more info, you can check the "Contribute Code" section in the development guide. |
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Please use #54456 instead. It's much better. |
What problem does this PR solve?
Issue Number: close #53336
Problem Summary:
It's not safe to call
Next
(or other method) of an executor after the session is executing the next statement. We have split out a lot ofContext
and it's clear that the context depended by theTableReaderExecutor
is safe to be re-used (after proper configuration) while executing another statement is running on the session.What changed and how does it work?
This PR adds
IntoStatic
method for several contexts. After calling this method, the context can be safe to be used while the session continues to run the next statements.Check List
Tests
TODO:
Side effects
Documentation
Release note
Please refer to Release Notes Language Style Guide to write a quality release note.