table: simplify the locate partition args for PartitionedTable
#53432
Conversation
ti-chi-bot
bot
added
release-note-none
|
Hi @lcwangchao. Thanks for your PR. PRs from untrusted users cannot be marked as trusted with I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
| if t.meta.Partition.Expr != "" { | ||
| e, err := expression.ParseSimpleExpr(ctx, t.meta.Partition.Expr, expression.WithTableInfo("", t.meta)) | ||
| if err == nil { | ||
| val, _, err := e.EvalInt(ctx.GetEvalCtx(), chunk.MutRowFromDatums(r).ToRow()) | ||
| if err == nil { | ||
| valueMsg = strconv.FormatInt(val, 10) | ||
| } | ||
| } |
There was a problem hiding this comment.
Seems this branch is only for range partitioning table, so I removed it. PTAL @mjonss
There was a problem hiding this comment.
Right, if it is RANGE COLUMNS, then t.meta.Partition.Expr should be empty, since it should only allow a list of columns.
| e, err := expression.ParseSimpleExpr(ctx, t.meta.Partition.Expr, expression.WithTableInfo("", t.meta)) | ||
| if err == nil { | ||
| val, _, err := e.EvalInt(ctx.GetEvalCtx(), chunk.MutRowFromDatums(r).ToRow()) | ||
| if err == nil { | ||
| if unsigned { | ||
| valueMsg = fmt.Sprintf("%d", uint64(val)) | ||
| } else { | ||
| valueMsg = fmt.Sprintf("%d", val) | ||
| } | ||
| } | ||
| } |
There was a problem hiding this comment.
The expression value seems already computed in the previous step and we can just use ret in the message. PTAL @mjonss
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #53432 +/- ##
================================================
+ Coverage 72.5410% 74.5121% +1.9711%
================================================
Files 1505 1505
Lines 429838 431139 +1301
================================================
+ Hits 311809 321251 +9442
+ Misses 98743 89959 -8784
- Partials 19286 19929 +643
Flags with carried forward coverage won't be shown. Click here to find out more.
|
|
/retest |
|
@lcwangchao: Cannot trigger testing until a trusted user reviews the PR and leaves an In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
|
/retest |
|
@lcwangchao: Cannot trigger testing until a trusted user reviews the PR and leaves an In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
ti-chi-bot
bot
added
lgtm
and removed
needs-1-more-lgtm
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: mjonss, qw4990, tangenta The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
What problem does this PR solve?
Issue Number: close #53431
Problem Summary:
Seems we can replace
expression.BuildContextwithexpression.EvalContextforPartitionedTablebecause we only need to "evaluate" an expression.What changed and how does it work?
expression.BuildContextwithexpression.EvalContextin some methods inPartitionedTableCheck List
Tests
Side effects
Documentation
Release note
Please refer to Release Notes Language Style Guide to write a quality release note.