-
Notifications
You must be signed in to change notification settings - Fork 5.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ddl,expression: introduce CtxWithHandleTruncateErrLevel
to wrap a expression context to handle truncate error
#53441
Conversation
…xpression context to handle truncate error
Hi @lcwangchao. Thanks for your PR. PRs from untrusted users cannot be marked as trusted with I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #53441 +/- ##
================================================
+ Coverage 72.5282% 75.2855% +2.7573%
================================================
Files 1505 1505
Lines 429845 429886 +41
================================================
+ Hits 311759 323642 +11883
+ Misses 98811 85953 -12858
- Partials 19275 20291 +1016
Flags with carried forward coverage won't be shown. Click here to find out more.
|
/retest |
@lcwangchao: Cannot trigger testing until a trusted user reviews the PR and leaves an In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
[LGTM Timeline notifier]Timeline:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: hawkingrei, windtalker, zimulala The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
What problem does this PR solve?
Issue Number: ref #53388
What changed and how does it work?
This PR removes
handleWithTruncateErr
and then introduceCtxWithHandleTruncateErrLevel
to make override truncate error handle in the context for some reasons:CtxWithHandleTruncateErrLevel
creates a new context without modifying the old context. It is more safe in concurrency.CtxWithHandleTruncateErrLevel
receivescontext.BuildContext
as an input. So we can replacemock.Context
with theNewStaticExprContext
to make code strong.Check List
Tests
Side effects
Documentation
Release note
Please refer to Release Notes Language Style Guide to write a quality release note.