planner: skip all system tables when collecting prediction columns #53443
Conversation
Signed-off-by: hi-rustin <rustin.liu@gmail.com>
Signed-off-by: hi-rustin <rustin.liu@gmail.com>
ti-chi-bot
bot
added
release-note
Rustin170506
changed the title
Signed-off-by: hi-rustin <rustin.liu@gmail.com>
| @@ -120,6 +120,36 @@ func MockInfoSchema(tbList []*model.TableInfo) InfoSchema { | |||
| bucketIdx := tableBucketIdx(tb.ID) | |||
| result.sortedTablesBuckets[bucketIdx] = append(result.sortedTablesBuckets[bucketIdx], tbl) | |||
| } | |||
| // Add a system table. | |||
| tables := []*model.TableInfo{ | |||
There was a problem hiding this comment.
Maybe we should find a better way to add a system table. But right now, we only need one system table. So I guess this way is OK. But if you have any suggestions please feel free to comment.
|
/retest |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #53443 +/- ##
================================================
+ Coverage 72.5268% 74.7824% +2.2556%
================================================
Files 1505 1505
Lines 429830 431775 +1945
================================================
+ Hits 311742 322892 +11150
+ Misses 98799 88976 -9823
- Partials 19289 19907 +618
Flags with carried forward coverage won't be shown. Click here to find out more.
|
ti-chi-bot
bot
added
lgtm
and removed
needs-1-more-lgtm
[LGTM Timeline notifier]Timeline:
|
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: hawkingrei, time-and-fate, winoros, zimulala The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
/retest |
What problem does this PR solve?
Issue Number: close #53403
Problem Summary:
What changed and how does it work?
We shouldn't collect stats usage for system tables. So in this PR, we do a check before we add them to the column map.
Check List
Tests
Side effects
Documentation
Release note
Please refer to Release Notes Language Style Guide to write a quality release note.