-
Notifications
You must be signed in to change notification settings - Fork 5.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ddl: support create sequences with BatchCreateTableWithInfo
#53465
Conversation
Hi @tangenta. Thanks for your PR. PRs from untrusted users cannot be marked as trusted with I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
/ok-to-test |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #53465 +/- ##
================================================
+ Coverage 72.5278% 75.9398% +3.4119%
================================================
Files 1505 1506 +1
Lines 429865 435750 +5885
================================================
+ Hits 311772 330908 +19136
+ Misses 98812 84627 -14185
- Partials 19281 20215 +934
Flags with carried forward coverage won't be shown. Click here to find out more.
|
if err != nil { | ||
return ver, errors.Trace(err) | ||
job.State = model.JobStateCancelled | ||
return errors.Trace(err) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
switch tbInfo.State { | ||
case model.StateNone: | ||
case model.StateNone, model.StatePublic: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why add model.StatePublic here?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The reason is the same as #51870. Maybe we can set this state on caller side, let's refactor these in next PR.
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: AilinKid, Leavrth, wjhuang2016 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Encounter an unstable test that will be fixed by #53566 |
/retest |
1 similar comment
/retest |
What problem does this PR solve?
Issue Number: close #53374
Problem Summary:
What changed and how does it work?
callHookOnChanged
afterBatchCreateTableWithInfo
.createSequenceWithCheck
.onCreateTables
.Check List
Tests
Side effects
Documentation
Release note
Please refer to Release Notes Language Style Guide to write a quality release note.