Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ddl: support create sequences with BatchCreateTableWithInfo #53465

Merged
merged 2 commits into from
May 28, 2024

Conversation

tangenta
Copy link
Contributor

@tangenta tangenta commented May 22, 2024

What problem does this PR solve?

Issue Number: close #53374

Problem Summary:

What changed and how does it work?

  • Invoke callHookOnChanged after BatchCreateTableWithInfo.
  • Refactor and extract createSequenceWithCheck.
  • Support create sequences in onCreateTables.

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No need to test
    • I checked and no code files have been changed.

Side effects

  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Breaking backward compatibility

Documentation

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Changes MySQL compatibility

Release note

Please refer to Release Notes Language Style Guide to write a quality release note.

None

@ti-chi-bot ti-chi-bot bot added do-not-merge/needs-triage-completed do-not-merge/needs-tests-checked release-note-none Denotes a PR that doesn't merit a release note. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels May 22, 2024
Copy link

tiprow bot commented May 22, 2024

Hi @tangenta. Thanks for your PR.

PRs from untrusted users cannot be marked as trusted with /ok-to-test in this repo meaning untrusted PR authors can never trigger tests themselves. Collaborators can still trigger tests on the PR using /test all.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@tangenta
Copy link
Contributor Author

/ok-to-test
/check-issue-triage-complete

@ti-chi-bot ti-chi-bot bot added ok-to-test Indicates a PR is ready to be tested. and removed do-not-merge/needs-triage-completed labels May 22, 2024
Copy link

codecov bot commented May 22, 2024

Codecov Report

Attention: Patch coverage is 54.54545% with 15 lines in your changes are missing coverage. Please review.

Project coverage is 75.9398%. Comparing base (d1b8c5b) to head (fe4c767).
Report is 30 commits behind head on master.

Additional details and impacted files
@@               Coverage Diff                @@
##             master     #53465        +/-   ##
================================================
+ Coverage   72.5278%   75.9398%   +3.4119%     
================================================
  Files          1505       1506         +1     
  Lines        429865     435750      +5885     
================================================
+ Hits         311772     330908     +19136     
+ Misses        98812      84627     -14185     
- Partials      19281      20215       +934     
Flag Coverage Δ
integration 51.2194% <48.4848%> (?)
unit 72.0504% <54.5454%> (+0.6338%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
dumpling 53.9957% <ø> (ø)
parser ∅ <ø> (∅)
br 61.2612% <ø> (+19.8640%) ⬆️

if err != nil {
return ver, errors.Trace(err)
job.State = model.JobStateCancelled
return errors.Trace(err)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ti-chi-bot ti-chi-bot bot added the needs-1-more-lgtm Indicates a PR needs 1 more LGTM. label May 22, 2024
@ti-chi-bot ti-chi-bot bot added lgtm and removed needs-1-more-lgtm Indicates a PR needs 1 more LGTM. labels May 23, 2024
Copy link

ti-chi-bot bot commented May 23, 2024

[LGTM Timeline notifier]

Timeline:

  • 2024-05-22 07:31:24.446939511 +0000 UTC m=+2243238.204075083: ☑️ agreed by AilinKid.
  • 2024-05-23 02:03:02.191722597 +0000 UTC m=+2309935.948858167: ☑️ agreed by Leavrth.

switch tbInfo.State {
case model.StateNone:
case model.StateNone, model.StatePublic:
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why add model.StatePublic here?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The reason is the same as #51870. Maybe we can set this state on caller side, let's refactor these in next PR.

Copy link

ti-chi-bot bot commented May 27, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: AilinKid, Leavrth, wjhuang2016

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot bot added the approved label May 27, 2024
@tangenta
Copy link
Contributor Author

Encounter an unstable test that will be fixed by #53566

@tangenta
Copy link
Contributor Author

/retest

1 similar comment
@tangenta
Copy link
Contributor Author

/retest

@ti-chi-bot ti-chi-bot bot merged commit f7cea6c into pingcap:master May 28, 2024
36 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved lgtm ok-to-test Indicates a PR is ready to be tested. release-note-none Denotes a PR that doesn't merit a release note. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

ddl.BatchCreateTableWithInfo is different from ddl.CreateTableWithInfo
4 participants