-
Notifications
You must be signed in to change notification settings - Fork 5.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
(DNM) expression: remove ctx from ParamMarker
#53487
Conversation
Signed-off-by: Yang Keao <yangkeao@chunibyo.icu>
Skipping CI for Draft Pull Request. |
[FORMAT CHECKER NOTIFICATION] Notice: To remove the For example:
📖 For more info, you can check the "Contribute Code" section in the development guide. |
Skipping CI for Draft Pull Request. |
/retest |
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #53487 +/- ##
================================================
+ Coverage 72.5278% 73.9423% +1.4144%
================================================
Files 1505 1505
Lines 429901 429889 -12
================================================
+ Hits 311798 317870 +6072
+ Misses 98809 92082 -6727
- Partials 19294 19937 +643
Flags with carried forward coverage won't be shown. Click here to find out more.
|
@YangKeao: The following test failed, say
Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
@@ -130,20 +129,13 @@ type Constant struct { | |||
|
|||
// ParamMarker indicates param provided by COM_STMT_EXECUTE. | |||
type ParamMarker struct { | |||
ctx variable.SessionVarsProvider |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
When the statement is using plan cache, the Value
is not set. Therefore, this PR is not correct. It's only an experiment to see what will happen if I removed it.
@YangKeao: The following tests failed, say
Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
What problem does this PR solve?
Issue Number: close #53485
Problem Summary:
As every execution will set the correct
Constant.Value
, there is no need to read the value from session context again.What changed and how does it work?
Remove the
ctx
field fromParamMarker
. Remove theGetUserVar
function, and useConstant.Value
as a replacement.Check List
TODO
Tests
Side effects
Documentation
Release note
Please refer to Release Notes Language Style Guide to write a quality release note.