*: update pingcap/errors version (#51854) #53526
Conversation
Signed-off-by: ti-chi-bot <ti-community-prow-bot@tidb.io>
ti-chi-bot
added
ok-to-test
| @@ -2087,7 +2087,7 @@ var defaultSysVars = []*SysVar{ | |||
| }}, | |||
| {Scope: ScopeGlobal | ScopeSession, Name: TiDBRedactLog, Value: BoolToOnOff(DefTiDBRedactLog), Type: TypeBool, SetSession: func(s *SessionVars, val string) error { | |||
| s.EnableRedactLog = TiDBOptOn(val) | |||
| errors.RedactLogEnabled.Store(s.EnableRedactLog) | |||
| errors.RedactLogEnabled.Store(val) | |||
There was a problem hiding this comment.
current master don't call TiDBOptOn, which doesn't support MARKER, see
tidb/pkg/sessionctx/variable/sysvar.go
Lines 2283 to 2284 in 9657f06
There was a problem hiding this comment.
This PR is not cherry-pick back to the release-7.5 branch, so still use TIDBOptOn
ti-chi-bot
bot
added
lgtm
and removed
needs-1-more-lgtm
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: D3Hunter, xhebox, yudongusa, YuJuncen The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## release-7.5 #53526 +/- ##
================================================
Coverage ? 72.0442%
================================================
Files ? 1411
Lines ? 410274
Branches ? 0
================================================
Hits ? 295579
Misses ? 94861
Partials ? 19834
Flags with carried forward coverage won't be shown. Click here to find out more.
|
This is an automated cherry-pick of #51854
What problem does this PR solve?
Issue Number: close #53517
Problem Summary:
What changed and how does it work?
update version to add this fix HasStack return true on empty stack to allow upper layer add stack again
Check List
Tests
only changed pkg/util/misc.go, existing cases should be enough to cover it
Side effects
Documentation
Release note
Please refer to Release Notes Language Style Guide to write a quality release note.