-
Notifications
You must be signed in to change notification settings - Fork 5.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
infoschema: fix issue of information schema cache miss cause by schema version gap (#53445) #53562
infoschema: fix issue of information schema cache miss cause by schema version gap (#53445) #53562
Conversation
…a version gap (pingcap#53445) close pingcap#53428 Signed-off-by: crazycs520 <crazycs520@gmail.com>
Skipping CI for Draft Pull Request. |
Hi @crazycs520. Thanks for your PR. PRs from untrusted users cannot be marked as trusted with I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
@lcwangchao @wjhuang2016 PTAL |
Signed-off-by: crazycs520 <crazycs520@gmail.com>
/retest-required |
@crazycs520: Cannot trigger testing until a trusted user reviews the PR and leaves an In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
Signed-off-by: crazycs520 <crazycs520@gmail.com>
[LGTM Timeline notifier]Timeline:
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: lcwangchao, tiancaiamao, wjhuang2016 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/retest-required |
@crazycs520: Cannot trigger testing until a trusted user reviews the PR and leaves an In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
/retest-required |
@crazycs520: Cannot trigger testing until a trusted user reviews the PR and leaves an In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
@crazycs520: The following tests failed, say
Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
a62856d
into
pingcap:tidb-6.5-with-kv-timeout-feature
Cherry-pick #53445 #47810
What problem does this PR solve?
Issue Number: close #53428
Problem Summary: fix issue of information schema cache miss cause by schema version gap
What changed and how does it work?
before this PR
When DDL has empty schema version, will cause cache miss, then stale-read query need to load snapshot schema from TiKV.
This PR
When DDL has empty schema version, this PR won't have schema cache miss, then won't cause many load snapshot schema operation.
Check List
Tests
Side effects
Documentation
Release note
Please refer to Release Notes Language Style Guide to write a quality release note.