Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

statistics: make sure that get max table id when to init stats #53606

Merged
merged 1 commit into from
May 28, 2024

Conversation

hawkingrei
Copy link
Member

@hawkingrei hawkingrei commented May 28, 2024

What problem does this PR solve?

Issue Number: close #53607

Problem Summary:

What changed and how does it work?

img_v3_02ba_1373cee3-9797-41d7-9d24-8cf3419c2bdg

img_v3_02ba_c7c7c6fc-ad7b-4158-b61e-2ce99a9bfd7g

GetMeta's SQL cannot order by table id. so initStatsMeta4Chunk cannot get max table id.

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No need to test
    • I checked and no code files have been changed.

Side effects

  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Breaking backward compatibility

Documentation

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Changes MySQL compatibility

Release note

Please refer to Release Notes Language Style Guide to write a quality release note.

None

Signed-off-by: Weizhen Wang <wangweizhen@pingcap.com>
@ti-chi-bot ti-chi-bot bot added do-not-merge/needs-linked-issue do-not-merge/needs-tests-checked release-note-none Denotes a PR that doesn't merit a release note. sig/planner SIG: Planner size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. and removed do-not-merge/needs-linked-issue do-not-merge/needs-tests-checked labels May 28, 2024
@ti-chi-bot ti-chi-bot bot added approved needs-1-more-lgtm Indicates a PR needs 1 more LGTM. labels May 28, 2024
Copy link

ti-chi-bot bot commented May 28, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: AilinKid, qw4990

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot bot added lgtm and removed needs-1-more-lgtm Indicates a PR needs 1 more LGTM. labels May 28, 2024
Copy link

ti-chi-bot bot commented May 28, 2024

[LGTM Timeline notifier]

Timeline:

  • 2024-05-28 05:49:09.529198582 +0000 UTC m=+2755503.286334156: ☑️ agreed by AilinKid.
  • 2024-05-28 06:02:10.393643561 +0000 UTC m=+2756284.150779133: ☑️ agreed by qw4990.

@hawkingrei hawkingrei changed the title statistics: make sure that get max table id statistics: make sure that get max table id when to init stats May 28, 2024
Copy link

codecov bot commented May 28, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 74.3857%. Comparing base (97aac23) to head (2c5496a).
Report is 1 commits behind head on master.

Additional details and impacted files
@@               Coverage Diff                @@
##             master     #53606        +/-   ##
================================================
+ Coverage   72.4404%   74.3857%   +1.9452%     
================================================
  Files          1507       1507                
  Lines        430584     430935       +351     
================================================
+ Hits         311917     320554      +8637     
+ Misses        99367      90452      -8915     
- Partials      19300      19929       +629     
Flag Coverage Δ
integration 48.4306% <100.0000%> (?)
unit 71.3557% <100.0000%> (-0.0683%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
dumpling 53.9957% <ø> (ø)
parser ∅ <ø> (∅)
br 50.3892% <ø> (+8.9308%) ⬆️

@ti-chi-bot ti-chi-bot added needs-cherry-pick-release-8.1 Should cherry pick this PR to release-8.1 branch. needs-cherry-pick-release-7.5 Should cherry pick this PR to release-7.5 branch. labels May 28, 2024
@ti-chi-bot ti-chi-bot bot merged commit bdb0545 into pingcap:master May 28, 2024
23 checks passed
@ti-chi-bot
Copy link
Member

In response to a cherrypick label: new pull request created to branch release-8.1: #53614.

@ti-chi-bot
Copy link
Member

In response to a cherrypick label: new pull request created to branch release-7.5: #53615.

ti-chi-bot pushed a commit to ti-chi-bot/tidb that referenced this pull request May 28, 2024
Signed-off-by: ti-chi-bot <ti-community-prow-bot@tidb.io>
@hawkingrei hawkingrei deleted the make_sure_get_max_tid branch July 3, 2024 07:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved lgtm needs-cherry-pick-release-7.5 Should cherry pick this PR to release-7.5 branch. needs-cherry-pick-release-8.1 Should cherry pick this PR to release-8.1 branch. release-note-none Denotes a PR that doesn't merit a release note. sig/planner SIG: Planner size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

cannot get max table id when to init stats
4 participants