Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

util: use runtime.Version() to get Go version #53619

Merged
merged 2 commits into from
May 29, 2024
+7 −5
Merged

util: use runtime.Version() to get Go version #53619

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
73c4eda
util: use runtime.Version() to get Go version
dveeden May 28, 2024
c78e4e4
Remove runtime and unsafe
dveeden May 28, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Next Next commit
Loading
Loading status checks…
util: use runtime.Version() to get Go version
@dveeden
dveeden committed May 28, 2024
commit 73c4edaaaeb4c631cf2f7e1459c8e2749e54452a
10 changes: 7 additions & 3 deletions pkg/util/printer/printer.go
View file
Original file line number Diff line number Diff line change
@@ -18,6 +18,7 @@ import (
"bytes"
"encoding/json"
"fmt"
"runtime"
_ "runtime" // import link package
_ "unsafe" // required by go:linkname

@@ -29,6 +30,12 @@ import (
"go.uber.org/zap"
)

var buildVersion string

func init() {
buildVersion = runtime.Version()
}

// PrintTiDBInfo prints the TiDB version information.
func PrintTiDBInfo() {
fields := []zap.Field{
@@ -175,6 +182,3 @@ func GetPrintResult(cols []string, datas [][]string) (string, bool) {
value = append(value, getPrintDivLine(maxColLen)...)
return string(value), true
}

//go:linkname buildVersion runtime.buildVersion
var buildVersion string