Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ddl: unify merging unique and non-unique index for multi-schema change #53632

Merged
merged 19 commits into from
Jun 5, 2024
Merged

ddl: unify merging unique and non-unique index for multi-schema change #53632

merged 19 commits into from
Jun 5, 2024

Conversation

lance6716
Copy link
Contributor

@lance6716 lance6716 commented May 28, 2024 •
edited
Loading

What problem does this PR solve?

Issue Number: close #53677

Problem Summary:

What changed and how does it work?

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No need to test
    • I checked and no code files have been changed.

Side effects

  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Breaking backward compatibility

Documentation

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Changes MySQL compatibility

Release note

Please refer to Release Notes Language Style Guide to write a quality release note.

None

@lance6716
ddl: unify merging unique and non-unique index for multi-schema change
64d3c2e 
Signed-off-by: lance6716 <lance6716@gmail.com>
@ti-chi-bot ti-chi-bot bot added do-not-merge/needs-linked-issue do-not-merge/needs-tests-checked do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. release-note-none Denotes a PR that doesn't merit a release note. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels May 28, 2024
@tiprow tiprow
Copy link

tiprow bot commented May 28, 2024

Hi @lance6716. Thanks for your PR.

PRs from untrusted users cannot be marked as trusted with /ok-to-test in this repo meaning untrusted PR authors can never trigger tests themselves. Collaborators can still trigger tests on the PR using /test all.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@codecov Codecov
Copy link

codecov bot commented May 28, 2024 •
edited
Loading

Codecov Report

Attention: Patch coverage is 87.07865% with 23 lines in your changes missing coverage. Please review.

Project coverage is 56.0185%. Comparing base (a6e1a2e) to head (a51d881).
Report is 1 commits behind head on master.

Additional details and impacted files 
@@                Coverage Diff                @@
##             master     #53632         +/-   ##
=================================================
- Coverage   72.5426%   56.0185%   -16.5241%     
=================================================
  Files          1506       1652        +146     
  Lines        431542     610096     +178554     
=================================================
+ Hits         313052     341767      +28715     
- Misses        99131     244521     +145390     
- Partials      19359      23808       +4449
Flag Coverage Δ
integration 38.4438% <85.3932%> (?)
unit 71.4294% <49.4382%> (-0.0997%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
dumpling 52.9656% <ø> (ø)
parser ∅ <ø> (∅)
br 50.5732% <ø> (+8.7649%) ⬆️

lance6716 added 2 commits May 29, 2024 10:38
@lance6716
fix IT
a4536ad 
Signed-off-by: lance6716 <lance6716@gmail.com>
@lance6716
save work
eb822e0 
Signed-off-by: lance6716 <lance6716@gmail.com>
@ti-chi-bot ti-chi-bot bot added size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. and removed size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels May 30, 2024
lance6716 added 2 commits May 30, 2024 15:00
@lance6716
Merge branch 'master' of github.com:pingcap/tidb into mixed-unique
224e417 
Signed-off-by: lance6716 <lance6716@gmail.com>
@lance6716
change more signature
73ae3bf 
Signed-off-by: lance6716 <lance6716@gmail.com>
@lance6716 lance6716 changed the title [WIP]ddl: unify merging unique and non-unique index for multi-schema change ddl: unify merging unique and non-unique index for multi-schema change May 30, 2024
@ti-chi-bot ti-chi-bot bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label May 30, 2024
lance6716 added 4 commits May 30, 2024 15:36
@lance6716
make bazel
588d2ea 
Signed-off-by: lance6716 <lance6716@gmail.com>
@lance6716
fix CI
f53a812 
Signed-off-by: lance6716 <lance6716@gmail.com>
@lance6716
fix IT
77ecb9b 
Signed-off-by: lance6716 <lance6716@gmail.com>
@lance6716
fix IT
db91c08 
Signed-off-by: lance6716 <lance6716@gmail.com>
@ti-chi-bot ti-chi-bot bot added size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. and removed size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. labels May 30, 2024
@lance6716
Copy link
Contributor Author

/retest

@tiprow tiprow
Copy link

tiprow bot commented May 31, 2024

@lance6716: Cannot trigger testing until a trusted user reviews the PR and leaves an /ok-to-test message.

In response to this:

/retest

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

D3Hunter
D3Hunter reviewed May 31, 2024
View reviewed changes
Copy link
Contributor

@D3Hunter D3Hunter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

will review later

tests/integrationtest/t/executor/infoschema_reader.test Show resolved Hide resolved
pkg/ddl/reorg.go Outdated Show resolved Hide resolved
@lance6716
address comment
c7d73e3 
Signed-off-by: lance6716 <lance6716@gmail.com>
@ti-chi-bot ti-chi-bot bot added size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. and removed size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. labels May 31, 2024
@ti-chi-bot ti-chi-bot bot removed the needs-1-more-lgtm Indicates a PR needs 1 more LGTM. label Jun 3, 2024
@ti-chi-bot ti-chi-bot
Copy link

ti-chi-bot bot commented Jun 3, 2024

[LGTM Timeline notifier]

Timeline:

  • 2024-06-03 03:25:35.095313284 +0000 UTC m=+3265288.852448854: ☑️ agreed by tangenta.
  • 2024-06-03 07:20:16.905795367 +0000 UTC m=+3279370.662930933: ☑️ agreed by D3Hunter.

@lance6716
Copy link
Contributor Author

/hold

wait to address comment

@ti-chi-bot ti-chi-bot bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jun 3, 2024
lance6716 added 3 commits June 3, 2024 15:47
@lance6716
align new unique index behaviour with BackendCtx.Register
ac4394b 
Signed-off-by: lance6716 <lance6716@gmail.com>
@lance6716
add another test and fix CI
d237eeb 
Signed-off-by: lance6716 <lance6716@gmail.com>
@lance6716
fix CI
ff8373a 
Signed-off-by: lance6716 <lance6716@gmail.com>
@lance6716
Copy link
Contributor Author

/retest

@tiprow tiprow
Copy link

tiprow bot commented Jun 3, 2024

@lance6716: Cannot trigger testing until a trusted user reviews the PR and leaves an /ok-to-test message.

In response to this:

/retest

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@lance6716
Copy link
Contributor Author

lance6716 commented Jun 4, 2024 •
edited
Loading

/hold

CI failed by #53789 #53791 #53792

@lance6716
Copy link
Contributor Author

/retest

@tiprow tiprow
Copy link

tiprow bot commented Jun 5, 2024

@lance6716: Cannot trigger testing until a trusted user reviews the PR and leaves an /ok-to-test message.

In response to this:

/retest

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@lance6716
Copy link
Contributor Author

/unhold

@ti-chi-bot ti-chi-bot bot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jun 5, 2024
@lance6716
Copy link
Contributor Author

/retest

@tiprow tiprow
Copy link

tiprow bot commented Jun 5, 2024

@lance6716: Cannot trigger testing until a trusted user reviews the PR and leaves an /ok-to-test message.

In response to this:

/retest

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@lance6716
fix CI
a51d881 
Signed-off-by: lance6716 <lance6716@gmail.com>
@ti-chi-bot ti-chi-bot bot merged commit 98a0a75 into pingcap:master Jun 5, 2024
22 checks passed
@lance6716 lance6716 mentioned this pull request Jun 12, 2024
Merged
13 tasks
@ti-chi-bot ti-chi-bot added the needs-cherry-pick-release-7.5 Should cherry pick this PR to release-7.5 branch. label Jul 22, 2024
@ti-chi-bot
Copy link
Member

In response to a cherrypick label: new pull request created to branch release-7.5: #54783.

ti-chi-bot pushed a commit to ti-chi-bot/tidb that referenced this pull request Jul 22, 2024
@lance6716 @ti-chi-bot
This is an automated cherry-pick of pingcap#53632
f61bf03 
Signed-off-by: ti-chi-bot <ti-community-prow-bot@tidb.io>
@ti-chi-bot ti-chi-bot mentioned this pull request Jul 22, 2024
Closed
13 tasks
@ti-chi-bot ti-chi-bot added the needs-cherry-pick-release-8.1 Should cherry pick this PR to release-8.1 branch. label Jul 30, 2024
@ti-chi-bot
Copy link
Member

In response to a cherrypick label: new pull request created to branch release-8.1: #55069.

ti-chi-bot pushed a commit to ti-chi-bot/tidb that referenced this pull request Jul 30, 2024
@lance6716 @ti-chi-bot
This is an automated cherry-pick of pingcap#53632
7e57e3e 
Signed-off-by: ti-chi-bot <ti-community-prow-bot@tidb.io>
@ti-chi-bot ti-chi-bot mentioned this pull request Jul 30, 2024
Closed
13 tasks
@ti-chi-bot ti-chi-bot removed the needs-cherry-pick-release-8.1 Should cherry pick this PR to release-8.1 branch. label Jul 31, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tangenta tangenta tangenta approved these changes

@D3Hunter D3Hunter D3Hunter approved these changes

Assignees
No one assigned
Labels
approved lgtm needs-cherry-pick-release-7.5 Should cherry pick this PR to release-7.5 branch. release-note-none Denotes a PR that doesn't merit a release note. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Support merge adding unique and non-unique index into one pass in multi-schema change
4 participants
@lance6716 @ti-chi-bot @D3Hunter @tangenta