-
Notifications
You must be signed in to change notification settings - Fork 5.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ddl: split sessionctx.Context
to sub contexts in CopContextBase
#53642
Conversation
Hi @lcwangchao. Thanks for your PR. PRs from untrusted users cannot be marked as trusted with I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
copCtx, err := copr.NewCopContextSingleIndex(tblInfo, idxInfo, tk.Session(), "") | ||
|
||
sctx := tk.Session() | ||
copCtx, err := ddl.NewReorgCopContext(store, ddl.NewDDLReorgMeta(sctx), tblInfo, []*model.IndexInfo{idxInfo}, "") |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Construct copCtx by ddl.NewReorgCopContext
instead of copr.NewCopContextSingleIndex
to make its inner state more like the one in production env.
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #53642 +/- ##
================================================
+ Coverage 72.5723% 74.5500% +1.9776%
================================================
Files 1506 1506
Lines 430741 431163 +422
================================================
+ Hits 312599 321432 +8833
+ Misses 98860 89787 -9073
- Partials 19282 19944 +662
Flags with carried forward coverage won't be shown. Click here to find out more.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: tangenta, YangKeao The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
What problem does this PR solve?
Issue Number: ref #53388
Problem Summary:
see description
What changed and how does it work?
This PR splits the
sessionctx.Context
inCopContextBase
into several sub-contexts to make it easier to removemock.Context
in the further PRs:NewReorgCopContext
to create acopr.CopContext
for reorg scene.NewReorgCopContext
still usesnewSessCtx
to create amock.Context
but then several sub-contexts are fetched from it as the input argument ofNewCopContext
.Check List
Tests
Side effects
Documentation
Release note
Please refer to Release Notes Language Style Guide to write a quality release note.