Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ddl: split sessionctx.Context to sub contexts in CopContextBase #53642

Merged
merged 2 commits into from
May 29, 2024

Conversation

lcwangchao
Copy link
Collaborator

What problem does this PR solve?

Issue Number: ref #53388

Problem Summary:

see description

What changed and how does it work?

This PR splits the sessionctx.Context in CopContextBase into several sub-contexts to make it easier to remove mock.Context in the further PRs:

  • introduce NewReorgCopContext to create a copr.CopContext for reorg scene.
  • NewReorgCopContext still uses newSessCtx to create a mock.Context but then several sub-contexts are fetched from it as the input argument of NewCopContext.
  • The current PR does equivalent substitution so there will no logic change.

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No need to test
    • I checked and no code files have been changed.

Side effects

  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Breaking backward compatibility

Documentation

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Changes MySQL compatibility

Release note

Please refer to Release Notes Language Style Guide to write a quality release note.

None

@ti-chi-bot ti-chi-bot bot added release-note-none Denotes a PR that doesn't merit a release note. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels May 29, 2024
Copy link

tiprow bot commented May 29, 2024

Hi @lcwangchao. Thanks for your PR.

PRs from untrusted users cannot be marked as trusted with /ok-to-test in this repo meaning untrusted PR authors can never trigger tests themselves. Collaborators can still trigger tests on the PR using /test all.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

pkg/ddl/index_cop.go Outdated Show resolved Hide resolved
copCtx, err := copr.NewCopContextSingleIndex(tblInfo, idxInfo, tk.Session(), "")

sctx := tk.Session()
copCtx, err := ddl.NewReorgCopContext(store, ddl.NewDDLReorgMeta(sctx), tblInfo, []*model.IndexInfo{idxInfo}, "")
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Construct copCtx by ddl.NewReorgCopContext instead of copr.NewCopContextSingleIndex to make its inner state more like the one in production env.

Copy link

codecov bot commented May 29, 2024

Codecov Report

Attention: Patch coverage is 92.50000% with 3 lines in your changes are missing coverage. Please review.

Project coverage is 74.5500%. Comparing base (e560d03) to head (569b246).
Report is 6 commits behind head on master.

Additional details and impacted files
@@               Coverage Diff                @@
##             master     #53642        +/-   ##
================================================
+ Coverage   72.5723%   74.5500%   +1.9776%     
================================================
  Files          1506       1506                
  Lines        430741     431163       +422     
================================================
+ Hits         312599     321432      +8833     
+ Misses        98860      89787      -9073     
- Partials      19282      19944       +662     
Flag Coverage Δ
integration 49.1588% <92.5000%> (?)
unit 71.4347% <87.5000%> (-0.1311%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
dumpling 53.9957% <ø> (ø)
parser ∅ <ø> (∅)
br 50.4810% <ø> (+8.6690%) ⬆️

@ti-chi-bot ti-chi-bot bot added approved needs-1-more-lgtm Indicates a PR needs 1 more LGTM. labels May 29, 2024
Copy link
Member

@YangKeao YangKeao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link

ti-chi-bot bot commented May 29, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: tangenta, YangKeao

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot bot added lgtm and removed needs-1-more-lgtm Indicates a PR needs 1 more LGTM. labels May 29, 2024
Copy link

ti-chi-bot bot commented May 29, 2024

[LGTM Timeline notifier]

Timeline:

  • 2024-05-29 08:09:26.723813639 +0000 UTC m=+2850320.480949212: ☑️ agreed by tangenta.
  • 2024-05-29 09:50:12.434118499 +0000 UTC m=+2856366.191254071: ☑️ agreed by YangKeao.

@ti-chi-bot ti-chi-bot bot merged commit fc2d0a6 into pingcap:master May 29, 2024
23 checks passed
@lcwangchao lcwangchao deleted the ddl_cop_ctx branch May 29, 2024 11:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved lgtm release-note-none Denotes a PR that doesn't merit a release note. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants