Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

executor: implement NextChunk for ReplaceExec #5370

Merged
merged 9 commits into from
Dec 21, 2017
Merged

executor: implement NextChunk for ReplaceExec #5370

merged 9 commits into from
Dec 21, 2017

Conversation

winkyao
Copy link
Contributor

@winkyao winkyao commented Dec 11, 2017

to #5261

@zz-jason zz-jason mentioned this pull request Dec 11, 2017
Closed
41 tasks
@coocood
Copy link
Member

coocood commented Dec 11, 2017

LGTM

@zimulala zimulala added the status/LGT1 Indicates that a PR has LGTM 1. label Dec 11, 2017
@XuHuaiyu XuHuaiyu changed the title executor: ReplaceExec suport NextChunk executor: ReplaceExec support NextChunk Dec 11, 2017
zz-jason
zz-jason previously approved these changes Dec 11, 2017
View reviewed changes
Copy link
Member

@zz-jason zz-jason left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@zz-jason
Copy link
Member

/run-all-tests

@zz-jason zz-jason changed the title executor: ReplaceExec support NextChunk executor: implement NextChunk for ReplaceExec Dec 11, 2017
@XuHuaiyu XuHuaiyu dismissed zz-jason’s stale review December 11, 2017 12:00

DNM, still work in process

@XuHuaiyu XuHuaiyu added the WIP label Dec 11, 2017
@winkyao winkyao removed the WIP label Dec 21, 2017
@winkyao
Copy link
Contributor Author

winkyao commented Dec 21, 2017

@coocood @zz-jason @XuHuaiyu PTAL

coocood
coocood approved these changes Dec 21, 2017
View reviewed changes
Copy link
Member

@coocood coocood left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@coocood coocood added status/LGT2 Indicates that a PR has LGTM 2. and removed status/LGT1 Indicates that a PR has LGTM 1. labels Dec 21, 2017
@coocood
Copy link
Member

coocood commented Dec 21, 2017

/run-all-tests

@zz-jason zz-jason merged commit 3c418c5 into pingcap:master Dec 21, 2017
@winkyao winkyao deleted the support_replaceexec_chunk branch January 8, 2018 08:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@coocood coocood coocood approved these changes

@zz-jason zz-jason zz-jason left review comments

Assignees
No one assigned
Labels
status/LGT2 Indicates that a PR has LGTM 2.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@winkyao @coocood @zz-jason @zimulala @XuHuaiyu