ddl: fix ingest job panic when reset engine failed

[tangenta]

What problem does this PR solve?

Issue Number: close #53679

Problem Summary:

ei.closedEngine should be empty unless all data has been written and all writers have been closed.

What changed and how does it work?

Use correct closedEngine.

Check List

Tests

• Unit test
• Integration test
• Manual test (add detailed scripts or steps below)
• No need to test

  • I checked and no code files have been changed.

Side effects

• Performance regression: Consumes more CPU
• Performance regression: Consumes more Memory
• Breaking backward compatibility

Documentation

• Affects user behaviors
• Contains syntax changes
• Contains variable changes
• Contains experimental features
• Changes MySQL compatibility

Release note

Please refer to Release Notes Language Style Guide to write a quality release note.

None

[tiprow]

Hi @tangenta. Thanks for your PR.

PRs from untrusted users cannot be marked as trusted with /ok-to-test in this repo meaning untrusted PR authors can never trigger tests themselves. Collaborators can still trigger tests on the PR using /test all.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

[codecov]

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 55.9347%. Comparing base (073f746) to head (292aa53).
Report is 9 commits behind head on master.

Additional details and impacted files

@@                Coverage Diff                @@
##             master     #53754         +/-   ##
=================================================
- Coverage   72.4954%   55.9347%   -16.5607%     
=================================================
  Files          1506       1626        +120     
  Lines        431172     603945     +172773     
=================================================
+ Hits         312580     337815      +25235     
- Misses        99191     242897     +143706     
- Partials      19401      23233       +3832     

Flag	Coverage Δ
integration	37.0544% <100.0000%> (?)
unit	71.4326% <0.0000%> (-0.0493%)	⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Components	Coverage Δ
dumpling	52.9656% <ø> (ø)
parser	∅ <ø> (∅)
br	50.5410% <ø> (+8.7517%)	⬆️

[ti-chi-bot]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: lance6716, wjhuang2016

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS [lance6716,wjhuang2016]
• pkg/ddl/OWNERS [wjhuang2016]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[ti-chi-bot]

[LGTM Timeline notifier]

Timeline:

• 2024-06-03 08:48:33.508070929 +0000 UTC m=+3284667.265206499: ☑️ agreed by wjhuang2016.
• 2024-06-03 09:34:51.754440248 +0000 UTC m=+3287445.511575832: ☑️ agreed by lance6716.

[hawkingrei]

/retest

[lance6716]

FAILED  addindextest4_test.TestAddIndexIngestFailures (2.0s)

[ti-chi-bot]

In response to a cherrypick label: new pull request created to branch release-8.1: #55001.