-
Notifications
You must be signed in to change notification settings - Fork 5.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
statistics: fix wrong NDV in the global stats when to disable async-merge-global-stats (#53762) #53804
statistics: fix wrong NDV in the global stats when to disable async-merge-global-stats (#53762) #53804
Conversation
Signed-off-by: ti-chi-bot <ti-community-prow-bot@tidb.io>
/retest |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: hawkingrei, winoros The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
[LGTM Timeline notifier]Timeline:
|
/retest |
4 similar comments
/retest |
/retest |
/retest |
/retest |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## release-7.1 #53804 +/- ##
================================================
Coverage ? 73.4606%
================================================
Files ? 1211
Lines ? 380431
Branches ? 0
================================================
Hits ? 279467
Misses ? 83126
Partials ? 17838 |
This is an automated cherry-pick of #53762
What problem does this PR solve?
Issue Number: close #53752
Problem Summary:
What changed and how does it work?
blockMergeGlobalStats doesn't notice that FMSketch contains empty objectives in all partition's stats. so we need to find nil to init global rightly.
Check List
Tests
run as the PR's description.
Side effects
Documentation
Release note
Please refer to Release Notes Language Style Guide to write a quality release note.