statistics: fix wrong NDV in the global stats when to disable async-merge-global-stats (#53762) #53804
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: ti-chi-bot <ti-community-prow-bot@tidb.io>
ti-chi-bot
added
release-note-none
Merged
13 tasks
ti-chi-bot
added
the
cherry-pick-approved
ti-chi-bot
bot
added
size/XL
ti-chi-bot
bot
added
size/M
hawkingrei
approved these changes
Jul 22, 2024
ti-chi-bot
bot
added
needs-1-more-lgtm
|
/retest |
winoros
approved these changes
Aug 28, 2024
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: hawkingrei, winoros The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
ti-chi-bot
bot
added
lgtm
and removed
needs-1-more-lgtm
[LGTM Timeline notifier]Timeline:
|
|
/retest |
4 similar comments
|
/retest |
|
/retest |
|
/retest |
|
/retest |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## release-7.1 #53804 +/- ##
================================================
Coverage ? 73.4606%
================================================
Files ? 1211
Lines ? 380431
Branches ? 0
================================================
Hits ? 279467
Misses ? 83126
Partials ? 17838 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is an automated cherry-pick of #53762
What problem does this PR solve?
Issue Number: close #53752
Problem Summary:
What changed and how does it work?
blockMergeGlobalStats doesn't notice that FMSketch contains empty objectives in all partition's stats. so we need to find nil to init global rightly.
Check List
Tests
run as the PR's description.
Side effects
Documentation
Release note
Please refer to Release Notes Language Style Guide to write a quality release note.