Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: fix data race in TestAdminCheckGlobalIndexDuringDDL #53817

Merged
merged 1 commit into from
Jun 5, 2024

Conversation

Defined2014
Copy link
Contributor

What problem does this PR solve?

Issue Number: close #53802

Problem Summary:

What changed and how does it work?

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No need to test
    • I checked and no code files have been changed.

Side effects

  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Breaking backward compatibility

Documentation

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Changes MySQL compatibility

Release note

Please refer to Release Notes Language Style Guide to write a quality release note.

None

Copy link

ti-chi-bot bot commented Jun 5, 2024

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

@ti-chi-bot ti-chi-bot bot added do-not-merge/needs-triage-completed do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. release-note-none Denotes a PR that doesn't merit a release note. labels Jun 5, 2024
@Defined2014 Defined2014 marked this pull request as ready for review June 5, 2024 02:25
@ti-chi-bot ti-chi-bot bot added size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. and removed do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. labels Jun 5, 2024
Copy link

tiprow bot commented Jun 5, 2024

Hi @Defined2014. Thanks for your PR.

PRs from untrusted users cannot be marked as trusted with /ok-to-test in this repo meaning untrusted PR authors can never trigger tests themselves. Collaborators can still trigger tests on the PR using /test all.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@ti-chi-bot ti-chi-bot bot added approved needs-1-more-lgtm Indicates a PR needs 1 more LGTM. labels Jun 5, 2024
Copy link

codecov bot commented Jun 5, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 55.3018%. Comparing base (a44d409) to head (3cd3ae5).

Additional details and impacted files
@@                Coverage Diff                @@
##             master     #53817         +/-   ##
=================================================
- Coverage   72.5940%   55.3018%   -17.2923%     
=================================================
  Files          1506       1626        +120     
  Lines        431531     602088     +170557     
=================================================
+ Hits         313266     332966      +19700     
- Misses        98979     246271     +147292     
- Partials      19286      22851       +3565     
Flag Coverage Δ
integration 22.1096% <ø> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
dumpling 52.9656% <ø> (ø)
parser ∅ <ø> (∅)
br 50.5970% <ø> (+8.7887%) ⬆️

@Defined2014
Copy link
Contributor Author

/run-check-issue-triage-complete

Copy link

ti-chi-bot bot commented Jun 5, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: hawkingrei, lance6716

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [hawkingrei,lance6716]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot bot added lgtm and removed needs-1-more-lgtm Indicates a PR needs 1 more LGTM. labels Jun 5, 2024
Copy link

ti-chi-bot bot commented Jun 5, 2024

[LGTM Timeline notifier]

Timeline:

  • 2024-06-05 02:49:51.857414346 +0000 UTC m=+3435945.614549915: ☑️ agreed by hawkingrei.
  • 2024-06-05 03:27:23.156495817 +0000 UTC m=+3438196.913631391: ☑️ agreed by lance6716.

@ti-chi-bot ti-chi-bot bot merged commit 0c9b665 into pingcap:master Jun 5, 2024
20 of 23 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved lgtm release-note-none Denotes a PR that doesn't merit a release note. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

DATA RACE in the TestAdminCheckGlobalIndexDuringDDL
3 participants