executor: support Chunk for TableDualExec #5395
Conversation
|
numDualRows is always 1. |
executor/builder.go
Outdated
| return nil | ||
| } | ||
| dualSchema := v.Schema() | ||
| if dualSchema.Len() == 0 { |
There was a problem hiding this comment.
the schema can not be empty, we need to use it to build a chunk for TableDualExec and append some value into it to indicate there exists some rows in that chunk.
There was a problem hiding this comment.
this work should be done in plan building stage
|
/run-all-tests |
…into dev/chunk/tabledual
|
/run-all-tests |
|
/run-all-tests |
|
@hanfei1991 @coocood PTAL |
|
@zz-jason |
|
Please resolve the conflicts. |
executor/adapter.go
Outdated
| if e.Schema().Len() == 0 { | ||
| return a.handleNoDelayExecutor(goCtx, e, ctx, pi) | ||
| } else if proj, ok := e.(*ProjectionExec); ok && proj.calculateNoDelay { |
There was a problem hiding this comment.
Please comment this condition branch. Why we need this?
plan/planbuilder.go
Outdated
| @@ -257,7 +270,11 @@ func (b *planBuilder) buildSet(v *ast.SetStmt) Plan { | |||
| vars.Value = ast.NewValueExpr(cn.Name.Name.O) | |||
| } | |||
| mockTablePlan := LogicalTableDual{}.init(b.ctx) | |||
| mockTablePlan.SetSchema(expression.NewSchema()) | |||
| mockTablePlan.SetSchema(expression.NewSchema(&expression.Column{ | |||
|
/run-all-tests |
|
/run-all-tests |
|
LGTM |
util/chunk/chunk.go
Outdated
| @@ -174,6 +186,7 @@ func (c *Chunk) Append(other *Chunk, begin, end int) { | |||
| dst.length++ | |||
| } | |||
| } | |||
| c.numVirtualRows += other.numVirtualRows | |||
There was a problem hiding this comment.
why add all other.numVirtualRows? if we call Append more than once
|
/run-all-tests |
|
/ok-to-test |
zimulala
added
status/LGT2
|
/rebuild |
|
/run-all-tests |
plan/planbuilder.go
Outdated
| p.SetChildren(dual) | ||
| p.self = p | ||
| p.SetSchema(expression.NewSchema()) |
There was a problem hiding this comment.
Could we remove this line?
to #5261