Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

*: update Azure library to fix security problem #53995

Merged
merged 1 commit into from
Jun 14, 2024

Conversation

hawkingrei
Copy link
Member

@hawkingrei hawkingrei commented Jun 13, 2024

What problem does this PR solve?

Issue Number: close #53990

Problem Summary:

What changed and how does it work?

ref https://github.com/pingcap/tidb/security/dependabot/76
image

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No need to test
    • I checked and no code files have been changed.

Side effects

  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Breaking backward compatibility

Documentation

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Changes MySQL compatibility

Release note

Please refer to Release Notes Language Style Guide to write a quality release note.

None

Signed-off-by: Weizhen Wang <wangweizhen@pingcap.com>
@ti-chi-bot ti-chi-bot bot added do-not-merge/needs-linked-issue do-not-merge/needs-tests-checked release-note-none Denotes a PR that doesn't merit a release note. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed do-not-merge/needs-linked-issue do-not-merge/needs-tests-checked labels Jun 13, 2024
@ti-chi-bot ti-chi-bot bot added approved needs-1-more-lgtm Indicates a PR needs 1 more LGTM. labels Jun 13, 2024
Copy link

codecov bot commented Jun 13, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 55.9038%. Comparing base (f124165) to head (debccd0).
Report is 5 commits behind head on master.

Additional details and impacted files
@@                Coverage Diff                @@
##             master     #53995         +/-   ##
=================================================
- Coverage   74.5222%   55.9038%   -18.6185%     
=================================================
  Files          1508       1628        +120     
  Lines        358470     604499     +246029     
=================================================
+ Hits         267140     337938      +70798     
- Misses        71953     243377     +171424     
- Partials      19377      23184       +3807     
Flag Coverage Δ
integration 37.4965% <ø> (?)
unit 71.4304% <ø> (-1.9830%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
dumpling 52.9656% <ø> (-2.2339%) ⬇️
parser ∅ <ø> (∅)
br 50.6129% <ø> (+6.7114%) ⬆️

@hawkingrei
Copy link
Member Author

/retest

@hawkingrei hawkingrei requested review from xhebox and Defined2014 June 13, 2024 08:03
Copy link
Member

@YangKeao YangKeao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ti-chi-bot ti-chi-bot bot added lgtm and removed needs-1-more-lgtm Indicates a PR needs 1 more LGTM. labels Jun 14, 2024
Copy link

ti-chi-bot bot commented Jun 14, 2024

[LGTM Timeline notifier]

Timeline:

  • 2024-06-13 06:36:08.243572607 +0000 UTC m=+619322.296884527: ☑️ agreed by lance6716.
  • 2024-06-14 01:42:34.135304074 +0000 UTC m=+688108.188615998: ☑️ agreed by YangKeao.

Copy link

ti-chi-bot bot commented Jun 14, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: lance6716, xhebox, YangKeao

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [YangKeao,lance6716,xhebox]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot bot merged commit f713512 into pingcap:master Jun 14, 2024
23 checks passed
@hawkingrei hawkingrei deleted the fix_0613_security branch June 14, 2024 03:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved lgtm release-note-none Denotes a PR that doesn't merit a release note. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Azure Identity Libraries and Microsoft Authentication Library Elevation of Privilege Vulnerability
4 participants