variable: add system variable 'tidb_resource_control_strict_mode' #54033
Conversation
ti-chi-bot
bot
added
release-note
|
Hi @glorv. Thanks for your PR. PRs from untrusted users cannot be marked as trusted with I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
|
/ok-to-test |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #54033 +/- ##
=================================================
- Coverage 72.4718% 56.4624% -16.0094%
=================================================
Files 1508 1637 +129
Lines 432045 616436 +184391
=================================================
+ Hits 313111 348055 +34944
- Misses 99516 244400 +144884
- Partials 19418 23981 +4563
Flags with carried forward coverage won't be shown. Click here to find out more.
|
|
@nolouch @tiancaiamao PTAL, thanks~ |
pkg/sessionctx/variable/sysvar.go
Outdated
| @@ -2779,6 +2779,15 @@ var defaultSysVars = []*SysVar{ | |||
| }, GetGlobal: func(ctx context.Context, vars *SessionVars) (string, error) { | |||
| return BoolToOnOff(EnableResourceControl.Load()), nil | |||
| }}, | |||
| {Scope: ScopeGlobal, Name: TiDBResourceControlStrictMode, Value: BoolToOnOff(DefTiDBResourceControlStrictMode), Type: TypeBool, SetGlobal: func(ctx context.Context, vars *SessionVars, s string) error { | |||
| if TiDBOptOn(s) != EnableResourceControl.Load() { | |||
There was a problem hiding this comment.
| if TiDBOptOn(s) != EnableResourceControl.Load() { | |
| if TiDBOptOn(s) != EnableResourceControlStrictMode.Load() { |
should be EnableResourceControlStrictMode?
There was a problem hiding this comment.
fixed. It's weird that unit test does not find this bug.
ti-chi-bot
bot
added
lgtm
and removed
needs-1-more-lgtm
|
/approve |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: 3pointer, easonn7, nolouch, qw4990 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
What problem does this PR solve?
Issue Number: ref #53440
Problem Summary:
Add new global variable
tidb_resource_control_strict_mode:RESOURCE_GROUP_ADMINorRESOURCE_GROUP_USERprivilege to executeSET RESOURCE GROUPor use hintRESOURCE_GROUP()to change current resource group.SET RESOURCE GROUPor use hintRESOURCE_GROUP()as before.For new cluster, the default value is 'ON', but for cluster upgraded from old version, the default value is 'OFF'.
What changed and how does it work?
Check List
Tests
Side effects
Documentation
Release note
Please refer to Release Notes Language Style Guide to write a quality release note.