-
Notifications
You must be signed in to change notification settings - Fork 5.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
*: panic guard for warnings #54043
*: panic guard for warnings #54043
Conversation
Signed-off-by: xhe <xw897002528@gmail.com>
Hi @xhebox. Thanks for your PR. PRs from untrusted users cannot be marked as trusted with I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
if warn != nil { | ||
err = warn.Error() | ||
} | ||
e.appendRow([]any{w.Level, int64(mysql.ErrUnknown), err}) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, but why is there an empty warning?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't know, maybe we can open a new issue? We should be able to track the source by 1105 code.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #54043 +/- ##
=================================================
- Coverage 72.8108% 54.7584% -18.0524%
=================================================
Files 1527 1646 +119
Lines 435912 607276 +171364
=================================================
+ Hits 317391 332535 +15144
- Misses 98875 252356 +153481
- Partials 19646 22385 +2739
Flags with carried forward coverage won't be shown. Click here to find out more.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, but please also add a test case, to prevent regressions. I would suggest an integration test just with the statements from the reported issue.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I added the hold label, so you can add a test, feel free to remove the label and merge it.
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: Defined2014, mjonss The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
[LGTM Timeline notifier]Timeline:
|
Signed-off-by: xhe <xw897002528@gmail.com>
Signed-off-by: xhe <xw897002528@gmail.com>
/unhold |
@xhebox: Cannot trigger testing until a trusted user reviews the PR and leaves an In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
/ok-to-test |
Signed-off-by: ti-chi-bot <ti-community-prow-bot@tidb.io>
In response to a cherrypick label: new pull request created to branch |
Signed-off-by: ti-chi-bot <ti-community-prow-bot@tidb.io>
In response to a cherrypick label: new pull request created to branch |
In response to a cherrypick label: new pull request created to branch |
What problem does this PR solve?
Issue Number: close #48756
Problem Summary:
Check List
Tests
Ref scripts in runtime error shown in warning instead of truncate #48756
Side effects
Documentation
Release note
Please refer to Release Notes Language Style Guide to write a quality release note.