Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ddl: refine BackendCtx.Flush to display Duplicate entry error #54182

Merged
merged 3 commits into from
Jun 25, 2024

Conversation

lance6716
Copy link
Contributor

@lance6716 lance6716 commented Jun 24, 2024

What problem does this PR solve?

Issue Number: close #54184

Problem Summary:

easier to let Flush do error convertion. In the old code we still missed some branches that convert lightning error to ErrKeyExists

What changed and how does it work?

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No need to test
    • I checked and no code files have been changed.

Side effects

  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Breaking backward compatibility

Documentation

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Changes MySQL compatibility

Release note

Please refer to Release Notes Language Style Guide to write a quality release note.

None

Signed-off-by: lance6716 <lance6716@gmail.com>
@ti-chi-bot ti-chi-bot bot added do-not-merge/needs-linked-issue do-not-merge/needs-tests-checked release-note-none Denotes a PR that doesn't merit a release note. do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Jun 24, 2024
Copy link

tiprow bot commented Jun 24, 2024

Hi @lance6716. Thanks for your PR.

PRs from untrusted users cannot be marked as trusted with /ok-to-test in this repo meaning untrusted PR authors can never trigger tests themselves. Collaborators can still trigger tests on the PR using /test all.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

Signed-off-by: lance6716 <lance6716@gmail.com>
@lance6716 lance6716 changed the title [WIP]ddl: refine BackendCtx.Flush to display Duplicate entry error ddl: refine BackendCtx.Flush to display Duplicate entry error Jun 24, 2024
@ti-chi-bot ti-chi-bot bot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Jun 24, 2024
@lance6716 lance6716 requested a review from tangenta June 24, 2024 10:33
Copy link

codecov bot commented Jun 24, 2024

Codecov Report

Attention: Patch coverage is 58.33333% with 20 lines in your changes missing coverage. Please review.

Project coverage is 56.0958%. Comparing base (6695d5e) to head (4b5aa70).
Report is 9 commits behind head on master.

Additional details and impacted files
@@                Coverage Diff                @@
##             master     #54182         +/-   ##
=================================================
- Coverage   74.7738%   56.0958%   -18.6781%     
=================================================
  Files          1521       1644        +123     
  Lines        361185     617771     +256586     
=================================================
+ Hits         270072     346544      +76472     
- Misses        71477     247109     +175632     
- Partials      19636      24118       +4482     
Flag Coverage Δ
integration 37.4279% <56.2500%> (?)
unit 71.9954% <18.7500%> (-1.6604%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
dumpling 52.9656% <ø> (-2.2339%) ⬇️
parser ∅ <ø> (∅)
br 53.1141% <ø> (+5.1435%) ⬆️

@lance6716
Copy link
Contributor Author

/check-issue-triage-complete

Signed-off-by: lance6716 <lance6716@gmail.com>
@ti-chi-bot ti-chi-bot bot added approved needs-1-more-lgtm Indicates a PR needs 1 more LGTM. labels Jun 24, 2024
Copy link

ti-chi-bot bot commented Jun 25, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: D3Hunter, tangenta

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot bot added lgtm and removed needs-1-more-lgtm Indicates a PR needs 1 more LGTM. labels Jun 25, 2024
Copy link

ti-chi-bot bot commented Jun 25, 2024

[LGTM Timeline notifier]

Timeline:

  • 2024-06-24 12:45:37.183747966 +0000 UTC m=+637263.669236814: ☑️ agreed by tangenta.
  • 2024-06-25 02:12:53.138925069 +0000 UTC m=+685699.624413894: ☑️ agreed by D3Hunter.

@ti-chi-bot ti-chi-bot bot merged commit 7211d3d into pingcap:master Jun 25, 2024
21 of 23 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved lgtm release-note-none Denotes a PR that doesn't merit a release note. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

error message is not "Duplicate enrty" but a lightning error class sometimes
3 participants