-
Notifications
You must be signed in to change notification settings - Fork 5.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
*: remove lichunzhu from owner of four components #54189
Conversation
Hi @Benjamin2037. Thanks for your PR. PRs from untrusted users cannot be marked as trusted with I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
/approve |
@wuhuizuo: adding LGTM is restricted to approvers and reviewers in OWNERS files. In response to this: Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
@Benjamin2037 Could you please give a more detailed reason? Since it is an open-source repo, why community contributors can not be the owner of the components? |
/hold since have comments |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't understand the motivation behind this PR. It appears you've removed @lichunzhu from several owner lists where he isn't the sole member. If progress is stalled due to an inactive owner, you can simply assign it to another one. Why remove them when we are an open-source project?
This is a drawback from the bot not the owner list. |
Actually, the owner is a mechanism to ensure before all prs merge into TiDB. The owner team of this components/dir must has at least one member to know the related changes and not cause any breaking or compatibility risks. That is why we need keep owner list always refresh to dev team members. But unfortunate, our owner definition did and owner life cycle are not very clearly to our developer. |
I will pause this pr merge, and wait more sync information to clarify this owner mechanism. |
The owner team should refer to the general open source maintainers/committers, not the dev team, the dev team will not own the component. If there is a dev team need to acting effectively on the component, keep a more tight eye on related PRs. Currently all the owners will receive notification and won't miss anything. And if @lichunzhu is bored with the notifications, he could give up the ownership on his own. |
PR needs rebase. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
49a2751
to
3419bde
Compare
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: Benjamin2037, lance6716, wuhuizuo The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Issue Number: ref #46911
Problem Summary:
As title mentioned.
Tests
Release note