Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

*: remove lichunzhu from owner of four components #54189

Closed
wants to merge 0 commits into from

Conversation

Benjamin2037
Copy link
Collaborator

Issue Number: ref #46911

Problem Summary:
As title mentioned.

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No need to test
    • I checked and no code files have been changed.

Release note

None

@ti-chi-bot ti-chi-bot bot added release-note-none Denotes a PR that doesn't merit a release note. do-not-merge/invalid-title labels Jun 25, 2024
@ti-chi-bot ti-chi-bot bot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Jun 25, 2024
Copy link

tiprow bot commented Jun 25, 2024

Hi @Benjamin2037. Thanks for your PR.

PRs from untrusted users cannot be marked as trusted with /ok-to-test in this repo meaning untrusted PR authors can never trigger tests themselves. Collaborators can still trigger tests on the PR using /test all.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@Benjamin2037 Benjamin2037 changed the title Remove lichunzhu from owner of four components. *:remove lichunzhu from owner of four components. Jun 25, 2024
@Benjamin2037 Benjamin2037 changed the title *:remove lichunzhu from owner of four components. *:remove lichunzhu from owner of four components. Jun 25, 2024
@Benjamin2037
Copy link
Collaborator Author

/approve

@ti-chi-bot ti-chi-bot bot added the approved label Jun 25, 2024
@Benjamin2037 Benjamin2037 changed the title *:remove lichunzhu from owner of four components. *: remove lichunzhu from owner of four components Jun 25, 2024
Copy link

ti-chi-bot bot commented Jun 25, 2024

@wuhuizuo: adding LGTM is restricted to approvers and reviewers in OWNERS files.

In response to this:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@ti-chi-bot ti-chi-bot bot added the needs-1-more-lgtm Indicates a PR needs 1 more LGTM. label Jun 25, 2024
@Lloyd-Pottiger
Copy link
Contributor

@Benjamin2037 Could you please give a more detailed reason? Since it is an open-source repo, why community contributors can not be the owner of the components?

@ywqzzy
Copy link
Contributor

ywqzzy commented Jun 25, 2024

/hold since have comments

@ti-chi-bot ti-chi-bot bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jun 25, 2024
Copy link
Member

@JmPotato JmPotato left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't understand the motivation behind this PR. It appears you've removed @lichunzhu from several owner lists where he isn't the sole member. If progress is stalled due to an inactive owner, you can simply assign it to another one. Why remove them when we are an open-source project?

@ti-chi-bot ti-chi-bot bot removed the needs-1-more-lgtm Indicates a PR needs 1 more LGTM. label Jun 25, 2024
Copy link

ti-chi-bot bot commented Jun 25, 2024

[LGTM Timeline notifier]

Timeline:

  • 2024-06-25 02:07:53.418476546 +0000 UTC m=+685399.903965370: ☑️ agreed by lance6716.
  • 2024-06-25 04:05:22.515920977 +0000 UTC m=+692449.001409808: ✖️🔁 reset by JmPotato.

@lance6716
Copy link
Contributor

My approving comes from this reason: by seeing the referring issue "Make assigning be appropriate and reviewing be efficient." It will improve the accuracy of this bot action

image

However, I don't know if the accuracy is just an intermediate goal and futher goodness will be hurt.

@ywqzzy
Copy link
Contributor

ywqzzy commented Jun 25, 2024

My approving comes from this reason: by seeing the referring issue "Make assigning be appropriate and reviewing be efficient." It will improve the accuracy of this bot action

image

However, I don't know if the accuracy is just an intermediate goal and futher goodness will be hurt.

This is a drawback from the bot not the owner list.
It's harmful to just remove the owner from owner list without notification.
Don't know why we have to remove owner, the previous owner won't lead huge change for the code base and won't harm the code base.

@Benjamin2037
Copy link
Collaborator Author

Actually, the owner is a mechanism to ensure before all prs merge into TiDB. The owner team of this components/dir must has at least one member to know the related changes and not cause any breaking or compatibility risks. That is why we need keep owner list always refresh to dev team members. But unfortunate, our owner definition did and owner life cycle are not very clearly to our developer.

@Benjamin2037
Copy link
Collaborator Author

I will pause this pr merge, and wait more sync information to clarify this owner mechanism.

@zhangyangyu
Copy link
Member

Actually, the owner is a mechanism to ensure before all prs merge into TiDB. The owner team of this components/dir must has at least one member to know the related changes and not cause any breaking or compatibility risks. That is why we need keep owner list always refresh to dev team members. But unfortunate, our owner definition did and owner life cycle are not very clearly to our developer.

The owner team should refer to the general open source maintainers/committers, not the dev team, the dev team will not own the component. If there is a dev team need to acting effectively on the component, keep a more tight eye on related PRs. Currently all the owners will receive notification and won't miss anything. And if @lichunzhu is bored with the notifications, he could give up the ownership on his own.

@ti-chi-bot ti-chi-bot bot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Jul 5, 2024
Copy link

ti-chi-bot bot commented Jul 5, 2024

PR needs rebase.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Copy link

ti-chi-bot bot commented Sep 2, 2024

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: Benjamin2037, lance6716, wuhuizuo

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. release-note-none Denotes a PR that doesn't merit a release note. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants