expression: fail ColumnSubstituteImpl if creating function returns error (#53716)

[ti-chi-bot]

This is an automated cherry-pick of #53716

What problem does this PR solve?

Issue Number: close #53580, close #53582, close #53603, close #53594

Problem Summary:

The following ColumnSubstituteImpl will fail if it returns nil for a function argument.

What changed and how does it work?

This PR makes the ColumnSubstituteImpl fail if the NewFunction returns an error. I traced back the change in ColumnSubstituteImpl function. Maybe the only reason why NewFunctionInternal is used here is that the developers were quite confident that it'll not return an error, and at that time the ColumnSubstituteImpl function didn't return the second value to indicate whether it successes or not.

Check List

Tests

• Unit test
• Integration test
• Manual test (add detailed scripts or steps below)
• No need to test

  • I checked and no code files have been changed.

Side effects

• Performance regression: Consumes more CPU
• Performance regression: Consumes more Memory
• Breaking backward compatibility

Documentation

• Affects user behaviors
• Contains syntax changes
• Contains variable changes
• Contains experimental features
• Changes MySQL compatibility

Release note

Please refer to Release Notes Language Style Guide to write a quality release note.

Fix the issue that the planner will panic if the predicates have error after column substitution.

[YangKeao]

LGTM

[codecov]

Codecov Report

Attention: Patch coverage is 40.00000% with 3 lines in your changes missing coverage. Please review.

Please upload report for BASE (release-7.5@3c599cd). Learn more about missing BASE report.

Additional details and impacted files

@@               Coverage Diff                @@
##             release-7.5     #54191   +/-   ##
================================================
  Coverage               ?   72.0878%           
================================================
  Files                  ?       1411           
  Lines                  ?     411021           
  Branches               ?          0           
================================================
  Hits                   ?     296296           
  Misses                 ?      94853           
  Partials               ?      19872           

Flag	Coverage Δ
unit	72.0878% <40.0000%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

Components	Coverage Δ
dumpling	53.9913% <0.0000%> (?)
parser	∅ <0.0000%> (?)
br	53.4840% <0.0000%> (?)

[ti-chi-bot]

[LGTM Timeline notifier]

Timeline:

• 2024-06-25 05:29:43.810513927 +0000 UTC m=+697510.296002759: ☑️ agreed by YangKeao.
• 2024-06-25 06:21:00.781070577 +0000 UTC m=+700587.266559408: ☑️ agreed by qw4990.

[qw4990]

/test check-dev2

[tiprow]

@qw4990: No presubmit jobs available for pingcap/tidb@release-7.5

In response to this:

/test check-dev2

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

[windtalker]

LGTM

[ti-chi-bot]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: qw4990, windtalker, YangKeao

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS [YangKeao,qw4990,windtalker]
• pkg/expression/OWNERS [windtalker]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[qw4990]

/retest

[qw4990]

/retest