-
Notifications
You must be signed in to change notification settings - Fork 5.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
parser: truncate keywords.go when re-creating it (#49634) #54221
parser: truncate keywords.go when re-creating it (#49634) #54221
Conversation
Signed-off-by: ti-chi-bot <ti-community-prow-bot@tidb.io>
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## release-7.5 #54221 +/- ##
================================================
Coverage ? 72.0278%
================================================
Files ? 1411
Lines ? 410759
Branches ? 0
================================================
Hits ? 295861
Misses ? 95010
Partials ? 19888
Flags with carried forward coverage won't be shown. Click here to find out more.
|
This reverts commit 5ee78bf.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: bb7133, dveeden The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
This is an automated cherry-pick of #49634
What problem does this PR solve?
Issue Number: ref #48801
Problem Summary:
The code added in #48807 doesn't truncate the file when re-creating it. This might lead to left over bits of previous versions if the new file is shorter.
What changed and how does it work?
Check List
Tests
Side effects
Documentation
Release note
Please refer to Release Notes Language Style Guide to write a quality release note.