Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

planner: add CloneForPlanCache method to Plan interface #54285

Merged
merged 8 commits into from
Jun 28, 2024

Conversation

qw4990
Copy link
Contributor

@qw4990 qw4990 commented Jun 27, 2024

What problem does this PR solve?

Issue Number: ref #54057

Problem Summary: planner: add CloneForPlanCache method to Plan interface

What changed and how does it work?

planner: add CloneForPlanCache method to Plan interface

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No need to test
    • I checked and no code files have been changed.

Side effects

  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Breaking backward compatibility

Documentation

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Changes MySQL compatibility

Release note

Please refer to Release Notes Language Style Guide to write a quality release note.

None

@ti-chi-bot ti-chi-bot bot added release-note-none Denotes a PR that doesn't merit a release note. sig/planner SIG: Planner size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Jun 27, 2024
Copy link

tiprow bot commented Jun 27, 2024

Hi @qw4990. Thanks for your PR.

PRs from untrusted users cannot be marked as trusted with /ok-to-test in this repo meaning untrusted PR authors can never trigger tests themselves. Collaborators can still trigger tests on the PR using /test all.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@ti-chi-bot ti-chi-bot bot added approved needs-1-more-lgtm Indicates a PR needs 1 more LGTM. labels Jun 27, 2024
@AilinKid
Copy link
Contributor

make bazel_prepare

@Rustin170506 Rustin170506 self-requested a review June 27, 2024 09:23
Copy link

codecov bot commented Jun 27, 2024

Codecov Report

Attention: Patch coverage is 52.08333% with 23 lines in your changes missing coverage. Please review.

Project coverage is 56.2371%. Comparing base (761b592) to head (e2ca976).
Report is 9 commits behind head on master.

Additional details and impacted files
@@                Coverage Diff                @@
##             master     #54285         +/-   ##
=================================================
- Coverage   72.8839%   56.2371%   -16.6468%     
=================================================
  Files          1523       1644        +121     
  Lines        435584     611910     +176326     
=================================================
+ Hits         317471     344121      +26650     
- Misses        98568     244525     +145957     
- Partials      19545      23264       +3719     
Flag Coverage Δ
integration 36.8600% <0.0000%> (?)
unit 71.7957% <52.0833%> (-0.0997%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
dumpling 52.9656% <ø> (ø)
parser ∅ <ø> (∅)
br 52.7489% <ø> (+6.5904%) ⬆️

Copy link

ti-chi-bot bot commented Jun 27, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: AilinKid, time-and-fate

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot bot added lgtm and removed needs-1-more-lgtm Indicates a PR needs 1 more LGTM. labels Jun 27, 2024
Copy link

ti-chi-bot bot commented Jun 27, 2024

[LGTM Timeline notifier]

Timeline:

  • 2024-06-27 09:19:51.053139168 +0000 UTC m=+884117.538628000: ☑️ agreed by AilinKid.
  • 2024-06-27 20:20:04.587452422 +0000 UTC m=+923731.072941254: ☑️ agreed by time-and-fate.

Copy link

tiprow bot commented Jun 27, 2024

@qw4990: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
fast_test_tiprow 6b87d31 link true /test fast_test_tiprow

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@qw4990
Copy link
Contributor Author

qw4990 commented Jun 28, 2024

/retest

Copy link

tiprow bot commented Jun 28, 2024

@qw4990: Cannot trigger testing until a trusted user reviews the PR and leaves an /ok-to-test message.

In response to this:

/retest

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@ti-chi-bot ti-chi-bot bot merged commit b9a31b2 into pingcap:master Jun 28, 2024
21 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved lgtm release-note-none Denotes a PR that doesn't merit a release note. sig/planner SIG: Planner size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants