Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

table: provide some binlog related methods for binlog in MutateContext #54433

Merged
merged 1 commit into from
Jul 10, 2024
Merged

table: provide some binlog related methods for binlog in MutateContext #54433

merged 1 commit into from
Jul 10, 2024

Conversation

lcwangchao
Copy link
Collaborator

What problem does this PR solve?

Issue Number: ref #54392, ref #54397

What changed and how does it work?

  • Add a new method EncodeBinlogRowData to EncodeRowBuffer to encode row data for binlog. And remove method GetColDataBuffer to ensure the inner slices are private.
  • Add BinlogEnabled and GetBinlogMutation to remove some references of SessionVars in MutateContext.
  • Add some unit tests

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No need to test
    • I checked and no code files have been changed.

Side effects

  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Breaking backward compatibility

Documentation

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Changes MySQL compatibility

Release note

Please refer to Release Notes Language Style Guide to write a quality release note.

None

@ti-chi-bot ti-chi-bot bot added release-note-none Denotes a PR that doesn't merit a release note. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Jul 4, 2024
@tiprow tiprow
Copy link

tiprow bot commented Jul 4, 2024

Hi @lcwangchao. Thanks for your PR.

PRs from untrusted users cannot be marked as trusted with /ok-to-test in this repo meaning untrusted PR authors can never trigger tests themselves. Collaborators can still trigger tests on the PR using /test all.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@codecov Codecov
Copy link

codecov bot commented Jul 4, 2024 •
edited
Loading

Codecov Report

Attention: Patch coverage is 17.54386% with 47 lines in your changes missing coverage. Please review.

Project coverage is 51.8267%. Comparing base (53dcc79) to head (0035492).
Report is 1 commits behind head on master.

Additional details and impacted files 
@@                Coverage Diff                @@
##             master     #54433         +/-   ##
=================================================
- Coverage   74.7702%   51.8267%   -22.9435%     
=================================================
  Files          1547       1692        +145     
  Lines        362064     613835     +251771     
=================================================
+ Hits         270716     318131      +47415     
- Misses        71748     272923     +201175     
- Partials      19600      22781       +3181
Flag Coverage Δ
integration 35.6965% <17.5438%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
dumpling 55.1994% <ø> (ø)
parser ∅ <ø> (∅)
br 40.4657% <ø> (-7.2283%) ⬇️

@lcwangchao lcwangchao force-pushed the mutatectxbinlog branch 3 times, most recently from 58679dd to cdf4b0c Compare July 4, 2024 08:57
@lcwangchao
Copy link
Collaborator Author

/retest

@tiprow tiprow
Copy link

tiprow bot commented Jul 4, 2024

@lcwangchao: Cannot trigger testing until a trusted user reviews the PR and leaves an /ok-to-test message.

In response to this:

/retest

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@ti-chi-bot ti-chi-bot bot added the needs-1-more-lgtm Indicates a PR needs 1 more LGTM. label Jul 9, 2024
YangKeao
YangKeao approved these changes Jul 9, 2024
View reviewed changes
Copy link
Member

@YangKeao YangKeao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ti-chi-bot ti-chi-bot bot added lgtm and removed needs-1-more-lgtm Indicates a PR needs 1 more LGTM. labels Jul 9, 2024
@ti-chi-bot ti-chi-bot
Copy link

ti-chi-bot bot commented Jul 9, 2024

[LGTM Timeline notifier]

Timeline:

  • 2024-07-09 06:34:58.395633094 +0000 UTC m=+339395.630867206: ☑️ agreed by tangenta.
  • 2024-07-09 10:18:25.650820561 +0000 UTC m=+352802.886054670: ☑️ agreed by YangKeao.

@ti-chi-bot ti-chi-bot bot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Jul 9, 2024
@ti-chi-bot ti-chi-bot bot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Jul 9, 2024
@lcwangchao
Copy link
Collaborator Author

/retest

@tiprow tiprow
Copy link

tiprow bot commented Jul 10, 2024

@lcwangchao: Cannot trigger testing until a trusted user reviews the PR and leaves an /ok-to-test message.

In response to this:

/retest

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@lcwangchao
Copy link
Collaborator Author

/retest

@tiprow tiprow
Copy link

tiprow bot commented Jul 10, 2024

@lcwangchao: Cannot trigger testing until a trusted user reviews the PR and leaves an /ok-to-test message.

In response to this:

/retest

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@ti-chi-bot ti-chi-bot
Copy link

ti-chi-bot bot commented Jul 10, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: lance6716, tangenta, YangKeao

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot bot added the approved label Jul 10, 2024
@lcwangchao
Copy link
Collaborator Author

/retest

@tiprow tiprow
Copy link

tiprow bot commented Jul 10, 2024

@lcwangchao: Cannot trigger testing until a trusted user reviews the PR and leaves an /ok-to-test message.

In response to this:

/retest

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@ti-chi-bot ti-chi-bot bot merged commit f158c65 into pingcap:master Jul 10, 2024
21 of 22 checks passed
@lcwangchao lcwangchao mentioned this pull request Jul 19, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tangenta tangenta tangenta approved these changes

@YangKeao YangKeao YangKeao approved these changes

@lance6716 lance6716 lance6716 approved these changes

@ekexium ekexium Awaiting requested review from ekexium

Assignees
No one assigned
Labels
approved lgtm release-note-none Denotes a PR that doesn't merit a release note. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@lcwangchao @lance6716 @YangKeao @tangenta @xzhangxian1008