Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ddl: fix check running ingest job #54543

Merged
merged 7 commits into from
Jul 12, 2024
Merged

ddl: fix check running ingest job #54543

merged 7 commits into from
Jul 12, 2024

Conversation

lance6716
Copy link
Contributor

What problem does this PR solve?

Issue Number: close #54540

Problem Summary:

What changed and how does it work?

after #54438 we don't update the DDL job table, so switch to new way

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No need to test
    • I checked and no code files have been changed.

Side effects

  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Breaking backward compatibility

Documentation

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Changes MySQL compatibility

Release note

Please refer to Release Notes Language Style Guide to write a quality release note.

None

Signed-off-by: lance6716 <lance6716@gmail.com>
@ti-chi-bot ti-chi-bot bot added do-not-merge/needs-triage-completed release-note-none Denotes a PR that doesn't merit a release note. labels Jul 10, 2024
@lance6716 lance6716 requested review from tangenta and D3Hunter and removed request for tangenta July 10, 2024 07:48
@ti-chi-bot ti-chi-bot bot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Jul 10, 2024
Copy link

tiprow bot commented Jul 10, 2024

Hi @lance6716. Thanks for your PR.

PRs from untrusted users cannot be marked as trusted with /ok-to-test in this repo meaning untrusted PR authors can never trigger tests themselves. Collaborators can still trigger tests on the PR using /test all.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

Signed-off-by: lance6716 <lance6716@gmail.com>
@lance6716 lance6716 requested a review from tangenta July 10, 2024 07:55
Copy link

codecov bot commented Jul 10, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 55.9940%. Comparing base (20168ba) to head (b7b9117).
Report is 12 commits behind head on master.

Additional details and impacted files
@@                Coverage Diff                @@
##             master     #54543         +/-   ##
=================================================
- Coverage   72.8260%   55.9940%   -16.8321%     
=================================================
  Files          1548       1670        +122     
  Lines        436242     609779     +173537     
=================================================
+ Hits         317698     341440      +23742     
- Misses        98981     244954     +145973     
- Partials      19563      23385       +3822     
Flag Coverage Δ
integration 37.1415% <100.0000%> (?)
unit 71.7669% <100.0000%> (-0.0903%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
dumpling 52.9656% <ø> (ø)
parser ∅ <ø> (∅)
br 52.2667% <ø> (+6.3752%) ⬆️

@lance6716
Copy link
Contributor Author

/retest

Copy link

tiprow bot commented Jul 10, 2024

@lance6716: Cannot trigger testing until a trusted user reviews the PR and leaves an /ok-to-test message.

In response to this:

/retest

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@lance6716 lance6716 changed the title ddl: switch to new way to check running ingest job [WIP]ddl: switch to new way to check running ingest job Jul 10, 2024
@ti-chi-bot ti-chi-bot bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Jul 10, 2024
Signed-off-by: lance6716 <lance6716@gmail.com>
@ti-chi-bot ti-chi-bot bot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Jul 11, 2024
@lance6716 lance6716 changed the title [WIP]ddl: switch to new way to check running ingest job ddl: switch to new way to check running ingest job Jul 11, 2024
@ti-chi-bot ti-chi-bot bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Jul 11, 2024
@lance6716 lance6716 changed the title ddl: switch to new way to check running ingest job [WIP]ddl: switch to new way to check running ingest job Jul 11, 2024
@ti-chi-bot ti-chi-bot bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Jul 11, 2024
@lance6716 lance6716 changed the title [WIP]ddl: switch to new way to check running ingest job [WIP]ddl: fix check running ingest job Jul 11, 2024
Signed-off-by: lance6716 <lance6716@gmail.com>
@lance6716 lance6716 changed the title [WIP]ddl: fix check running ingest job ddl: fix check running ingest job Jul 11, 2024
@ti-chi-bot ti-chi-bot bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Jul 11, 2024
@ti-chi-bot ti-chi-bot bot added size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. and removed size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Jul 11, 2024
@ti-chi-bot ti-chi-bot bot added approved needs-1-more-lgtm Indicates a PR needs 1 more LGTM. labels Jul 11, 2024
@lance6716
Copy link
Contributor Author

/cc @D3Hunter

Copy link

ti-chi-bot bot commented Jul 12, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: D3Hunter, tangenta

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot bot added lgtm and removed needs-1-more-lgtm Indicates a PR needs 1 more LGTM. labels Jul 12, 2024
Copy link

ti-chi-bot bot commented Jul 12, 2024

[LGTM Timeline notifier]

Timeline:

  • 2024-07-11 07:25:29.782611675 +0000 UTC m=+515227.017845789: ☑️ agreed by tangenta.
  • 2024-07-12 02:02:52.200596382 +0000 UTC m=+582269.435830495: ☑️ agreed by D3Hunter.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved lgtm release-note-none Denotes a PR that doesn't merit a release note. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

flaky test in the TestCreateNonUniqueIndex
4 participants