-
Notifications
You must be signed in to change notification settings - Fork 5.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
executor/simple: prohibit setting a resource group to a role (#54525) #54551
executor/simple: prohibit setting a resource group to a role (#54525) #54551
Conversation
Signed-off-by: JmPotato <ghzpotato@gmail.com>
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## release-8.1 #54551 +/- ##
================================================
Coverage ? 71.3051%
================================================
Files ? 1465
Lines ? 422281
Branches ? 0
================================================
Hits ? 301108
Misses ? 100750
Partials ? 20423
Flags with carried forward coverage won't be shown. Click here to find out more.
|
/retest-required |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: JmPotato, nolouch, tangenta The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/test build |
@JmPotato: No presubmit jobs available for pingcap/tidb@release-8.1 In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
This is an automated cherry-pick of #54525
What problem does this PR solve?
Issue Number: close #54417, ref #54434.
What changed and how does it work?
Check if a user is a role before assigning a resource group to it.
Check List
Tests
Release note
Please refer to Release Notes Language Style Guide to write a quality release note.