lightning: make table in BaseKVEncoder private and provide some wrapped methods

[lcwangchao]

What problem does this PR solve?

Issue Number: ref #54397

What changed and how does it work?

This PR makes the table in BaseKVEncoder private. It ensures the outside code can only access the table via some unified methods which wraps some common logics.

For example, we expose BaseKVEncoder.AddRecord instead of BaseKVEncoder.Table.AddRecord. In some further PRs, we will use some common options when adding a record to the table, and this wrap can use all scenes to use the same code.

Check List

Tests

• Unit test
• Integration test
• Manual test (add detailed scripts or steps below)
• No need to test

  • I checked and no code files have been changed.

Side effects

• Performance regression: Consumes more CPU
• Performance regression: Consumes more Memory
• Breaking backward compatibility

Documentation

• Affects user behaviors
• Contains syntax changes
• Contains variable changes
• Contains experimental features
• Changes MySQL compatibility

Release note

Please refer to Release Notes Language Style Guide to write a quality release note.

None

[tiprow]

Hi @lcwangchao. Thanks for your PR.

PRs from untrusted users cannot be marked as trusted with /ok-to-test in this repo meaning untrusted PR authors can never trigger tests themselves. Collaborators can still trigger tests on the PR using /test all.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

[codecov]

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 56.7284%. Comparing base (9794156) to head (04c0c28).
Report is 12 commits behind head on master.

Additional details and impacted files

@@                Coverage Diff                @@
##             master     #54673         +/-   ##
=================================================
- Coverage   72.7250%   56.7284%   -15.9967%     
=================================================
  Files          1551       1697        +146     
  Lines        437068     622196     +185128     
=================================================
+ Hits         317858     352962      +35104     
- Misses        99629     245462     +145833     
- Partials      19581      23772       +4191     

Flag	Coverage Δ
integration	38.9664% <100.0000%> (?)
unit	72.3860% <100.0000%> (+0.6318%)	⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Components	Coverage Δ
dumpling	52.9656% <ø> (ø)
parser	∅ <ø> (∅)
br	52.6249% <ø> (+6.7925%)	⬆️

[lcwangchao]

/retest

[tiprow]

@lcwangchao: Cannot trigger testing until a trusted user reviews the PR and leaves an /ok-to-test message.

In response to this:

/retest

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

[lcwangchao]

/retest

[tiprow]

@lcwangchao: Cannot trigger testing until a trusted user reviews the PR and leaves an /ok-to-test message.

In response to this:

/retest

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

[ti-chi-bot]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: lance6716, tangenta

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• pkg/executor/importer/OWNERS [lance6716]
• pkg/lightning/OWNERS [lance6716]
• pkg/table/OWNERS [tangenta]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[ti-chi-bot]

[LGTM Timeline notifier]

Timeline:

• 2024-07-17 10:12:42.116694918 +0000 UTC m=+435184.107636373: ☑️ agreed by lance6716.
• 2024-07-17 12:39:32.58340537 +0000 UTC m=+443994.574346840: ☑️ agreed by tangenta.

[tiprow]

@lcwangchao: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name	Commit	Details	Required	Rerun command
fast_test_tiprow	04c0c28	link	true	/test fast_test_tiprow

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

[lcwangchao]

/retest

[tiprow]

@lcwangchao: Cannot trigger testing until a trusted user reviews the PR and leaves an /ok-to-test message.

In response to this:

/retest

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

[lcwangchao]

/retest

[tiprow]

@lcwangchao: Cannot trigger testing until a trusted user reviews the PR and leaves an /ok-to-test message.

In response to this:

/retest

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.