Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

log_backup: fix panic during advancer owner transfer (#52671) #54708

Merged
merged 5 commits into from
Aug 2, 2024
Merged

log_backup: fix panic during advancer owner transfer (#52671) #54708

merged 5 commits into from
Aug 2, 2024

Conversation

ti-chi-bot
Copy link
Member

This is an automated cherry-pick of #52671

What problem does this PR solve?

Issue Number: close #52597

Problem Summary:

  1. When losing the advancer ownership, the channel for subscription may be full.
  2. the consumer has already gone due to the canceled context. Hence making the producer(subscription) goroutine stuck.
  3. After the graceful shutdown period, the output channel will be eventually closed and we will get a send on closed channel panic.

What changed and how does it work?

  • When sending to the channel, also select the context.
  • Catch all panic and convert them to errors (so we can retry.)

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No need to test
    • I checked and no code files have been changed.

Side effects

  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Breaking backward compatibility

Documentation

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Changes MySQL compatibility

Release note

Please refer to Release Notes Language Style Guide to write a quality release note.

Fixed a bug where TiDB may panic when log backup enabled and PD is unreachable.

@YuJuncen @ti-chi-bot
This is an automated cherry-pick of pingcap#52671
70169a0 
Signed-off-by: ti-chi-bot <ti-community-prow-bot@tidb.io>
@ti-chi-bot ti-chi-bot added ok-to-test Indicates a PR is ready to be tested. release-note Denotes a PR that will be considered when it comes time to generate release notes. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. type/cherry-pick-for-release-8.1 This PR is cherry-picked to release-8.1 from a source PR. labels Jul 18, 2024
@ti-chi-bot ti-chi-bot mentioned this pull request Jul 18, 2024
Merged
13 tasks
@ti-chi-bot ti-chi-bot added the cherry-pick-approved Cherry pick PR approved by release team. label Jul 18, 2024
BornChanger and others added 2 commits July 31, 2024 17:22
@BornChanger
Update BUILD.bazel
459cfb7
@YuJuncen
resolve conflicts
4b49f79 
Signed-off-by: hillium <yujuncen@pingcap.com>
@ti-chi-bot ti-chi-bot bot added approved needs-1-more-lgtm Indicates a PR needs 1 more LGTM. labels Jul 31, 2024
@ti-chi-bot ti-chi-bot bot added lgtm and removed needs-1-more-lgtm Indicates a PR needs 1 more LGTM. labels Aug 1, 2024
@ti-chi-bot ti-chi-bot
Copy link

ti-chi-bot bot commented Aug 1, 2024

[LGTM Timeline notifier]

Timeline:

  • 2024-07-31 09:59:14.054136887 +0000 UTC m=+349870.334184955: ☑️ agreed by YuJuncen.
  • 2024-08-01 08:01:53.921899669 +0000 UTC m=+429230.201947738: ☑️ agreed by Leavrth.

Tristan1900
Tristan1900 approved these changes Aug 1, 2024
View reviewed changes
br/pkg/streamhelper/BUILD.bazel Show resolved Hide resolved
br/pkg/streamhelper/advancer.go
@@ -724,3 +724,12 @@ func (c *CheckpointAdvancer) asyncResolveLocksForRanges(ctx context.Context, tar
c.inResolvingLock.Store(false)
}()
}

func (c *CheckpointAdvancer) TEST_registerCallbackForSubscriptions(f func()) int {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: I searched in the codebase but couldn't find a common naming pattern of writing test only method.
what do you think of RegisterCallbackForSubscriptions_TEST_ONLY, up to you!

Copy link
Contributor

@YuJuncen YuJuncen Aug 2, 2024 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In fact this naming pattern is from rocksdb... (Also TEST as a prefix can somehow help us find those methods faster.)

@ti-chi-bot ti-chi-bot
Copy link

ti-chi-bot bot commented Aug 1, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: Leavrth, Tristan1900, YuJuncen

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot
Copy link

ti-chi-bot bot commented Aug 1, 2024

@Tristan1900: adding LGTM is restricted to approvers and reviewers in OWNERS files.

In response to this:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@YuJuncen
Copy link
Contributor

YuJuncen commented Aug 2, 2024

/test unit-test

@tiprow tiprow
Copy link

tiprow bot commented Aug 2, 2024

@YuJuncen: No presubmit jobs available for pingcap/tidb@release-8.1

In response to this:

/test unit-test

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@YuJuncen
fixed test cases (but why)
0c3e06c 
Signed-off-by: hillium <yujuncen@pingcap.com>
@codecov Codecov
Copy link

codecov bot commented Aug 2, 2024 •
edited
Loading

Codecov Report

Attention: Patch coverage is 95.55556% with 2 lines in your changes missing coverage. Please review.

Please upload report for BASE (release-8.1@ae394c6). Learn more about missing BASE report.

Additional details and impacted files 
@@               Coverage Diff                @@
##             release-8.1     #54708   +/-   ##
================================================
  Coverage               ?   71.2186%           
================================================
  Files                  ?       1465           
  Lines                  ?     422409           
  Branches               ?          0           
================================================
  Hits                   ?     300834           
  Misses                 ?     101111           
  Partials               ?      20464
Flag Coverage Δ
unit 71.2186% <95.5555%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
dumpling 53.9957% <0.0000%> (?)
parser ∅ <0.0000%> (?)
br 41.3500% <0.0000%> (?)

@BornChanger
Copy link
Contributor

/retest

@ti-chi-bot ti-chi-bot bot merged commit 9f7e0f1 into pingcap:release-8.1 Aug 2, 2024
18 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@YuJuncen YuJuncen YuJuncen approved these changes

@Leavrth Leavrth Leavrth approved these changes

@Tristan1900 Tristan1900 Tristan1900 approved these changes

Assignees

@YuJuncen YuJuncen

Labels
approved cherry-pick-approved Cherry pick PR approved by release team. lgtm ok-to-test Indicates a PR is ready to be tested. release-note Denotes a PR that will be considered when it comes time to generate release notes. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. type/cherry-pick-for-release-8.1 This PR is cherry-picked to release-8.1 from a source PR.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@ti-chi-bot @YuJuncen @BornChanger @Tristan1900 @Leavrth