Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tables: reduce GetSessionVars from MutateContext in tables #54715

Merged
merged 1 commit into from
Jul 19, 2024

Conversation

lcwangchao
Copy link
Collaborator

@lcwangchao lcwangchao commented Jul 18, 2024

What problem does this PR solve?

Issue Number: ref #54397

Problem Summary:

We will remove GetSessionVars in MutateContext step by step, see #54397. This PR does some simple replaces.

What changed and how does it work?

  • Replace GetSessionVars(). RowEncoder with GetRowEncodingConfig().RowEncoder
  • Replace GetSessionVars().StmtCtx.TypeCtx/ErrCtx/Location with GetSessionVars().GetEvalCtx().TypeCtx/ErrCtx/Location

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No need to test
    • I checked and no code files have been changed.

Side effects

  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Breaking backward compatibility

Documentation

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Changes MySQL compatibility

Release note

Please refer to Release Notes Language Style Guide to write a quality release note.

None

@ti-chi-bot ti-chi-bot bot added release-note-none Denotes a PR that doesn't merit a release note. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Jul 18, 2024
Copy link

tiprow bot commented Jul 18, 2024

Hi @lcwangchao. Thanks for your PR.

PRs from untrusted users cannot be marked as trusted with /ok-to-test in this repo meaning untrusted PR authors can never trigger tests themselves. Collaborators can still trigger tests on the PR using /test all.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@@ -94,6 +94,9 @@ func (ctx *Context) AppendWarning(err error) {
// It also allows using `errors.ErrorGroup`, in this case, it'll handle each error in order, and return the first error
// it founds.
func (ctx *Context) HandleError(err error) error {
if err == nil {
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is to make HandleError to return quickly and easier to understand. PTAL @YangKeao

Copy link

codecov bot commented Jul 18, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 56.0540%. Comparing base (1c078a0) to head (c519f3d).
Report is 11 commits behind head on master.

Additional details and impacted files
@@                Coverage Diff                @@
##             master     #54715         +/-   ##
=================================================
- Coverage   72.6810%   56.0540%   -16.6271%     
=================================================
  Files          1551       1673        +122     
  Lines        437176     611537     +174361     
=================================================
+ Hits         317744     342791      +25047     
- Misses        99813     245311     +145498     
- Partials      19619      23435       +3816     
Flag Coverage Δ
integration 37.2831% <100.0000%> (?)
unit 71.7466% <92.5000%> (+0.0490%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
dumpling 52.9656% <ø> (ø)
parser ∅ <ø> (∅)
br 52.4779% <ø> (+6.6375%) ⬆️

@lcwangchao
Copy link
Collaborator Author

/retest

Copy link

tiprow bot commented Jul 18, 2024

@lcwangchao: Cannot trigger testing until a trusted user reviews the PR and leaves an /ok-to-test message.

In response to this:

/retest

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

Copy link
Member

@YangKeao YangKeao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ti-chi-bot ti-chi-bot bot added the needs-1-more-lgtm Indicates a PR needs 1 more LGTM. label Jul 18, 2024
Copy link

ti-chi-bot bot commented Jul 19, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: tangenta, YangKeao

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot bot added approved lgtm and removed needs-1-more-lgtm Indicates a PR needs 1 more LGTM. labels Jul 19, 2024
Copy link

ti-chi-bot bot commented Jul 19, 2024

[LGTM Timeline notifier]

Timeline:

  • 2024-07-18 08:58:50.58933358 +0000 UTC m=+517152.580275052: ☑️ agreed by YangKeao.
  • 2024-07-19 01:48:24.154527833 +0000 UTC m=+577726.145469303: ☑️ agreed by tangenta.

@ti-chi-bot ti-chi-bot bot merged commit 708cbfe into pingcap:master Jul 19, 2024
23 checks passed
@lcwangchao lcwangchao deleted the tblctx_ctx branch July 19, 2024 03:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved lgtm release-note-none Denotes a PR that doesn't merit a release note. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants