-
Notifications
You must be signed in to change notification settings - Fork 5.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
tables: reduce GetSessionVars
from MutateContext
in tables
#54715
Conversation
Hi @lcwangchao. Thanks for your PR. PRs from untrusted users cannot be marked as trusted with I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
@@ -94,6 +94,9 @@ func (ctx *Context) AppendWarning(err error) { | |||
// It also allows using `errors.ErrorGroup`, in this case, it'll handle each error in order, and return the first error | |||
// it founds. | |||
func (ctx *Context) HandleError(err error) error { | |||
if err == nil { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is to make HandleError
to return quickly and easier to understand. PTAL @YangKeao
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #54715 +/- ##
=================================================
- Coverage 72.6810% 56.0540% -16.6271%
=================================================
Files 1551 1673 +122
Lines 437176 611537 +174361
=================================================
+ Hits 317744 342791 +25047
- Misses 99813 245311 +145498
- Partials 19619 23435 +3816
Flags with carried forward coverage won't be shown. Click here to find out more.
|
/retest |
@lcwangchao: Cannot trigger testing until a trusted user reviews the PR and leaves an In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: tangenta, YangKeao The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
What problem does this PR solve?
Issue Number: ref #54397
Problem Summary:
We will remove
GetSessionVars
inMutateContext
step by step, see #54397. This PR does some simple replaces.What changed and how does it work?
GetSessionVars(). RowEncoder
withGetRowEncodingConfig().RowEncoder
GetSessionVars().StmtCtx.TypeCtx/ErrCtx/Location
withGetSessionVars().GetEvalCtx().TypeCtx/ErrCtx/Location
Check List
Tests
Side effects
Documentation
Release note
Please refer to Release Notes Language Style Guide to write a quality release note.