-
Notifications
You must be signed in to change notification settings - Fork 5.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
table: expose some fields to MutateContext
from GetSessionVars()
#54767
Conversation
Hi @lcwangchao. Thanks for your PR. PRs from untrusted users cannot be marked as trusted with I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
// InRestrictedSQL returns whether the current context is used in restricted SQL. | ||
func (ctx *TableContextImpl) InRestrictedSQL() bool { | ||
return ctx.vars().StmtCtx.InRestrictedSQL |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I found StmtCtx
and SessionVars
all have InRestrictedSQL
and they are kept the same in ResetContextOfStmt
:
Line 1946 in 2da324d
sc.InRestrictedSQL = vars.InRestrictedSQL |
Read it from SessionVars
instead of StmtCtx
keeps the same behavior as previous implementations.
1e26d26
to
eeb60c9
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #54767 +/- ##
=================================================
- Coverage 72.8076% 56.3129% -16.4947%
=================================================
Files 1552 1676 +124
Lines 437303 613374 +176071
=================================================
+ Hits 318390 345409 +27019
- Misses 99290 244544 +145254
- Partials 19623 23421 +3798
Flags with carried forward coverage won't be shown. Click here to find out more.
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: tangenta, YangKeao The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/retest |
@lcwangchao: Cannot trigger testing until a trusted user reviews the PR and leaves an In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
What problem does this PR solve?
Issue Number: ref #54397
What changed and how does it work?
expose some fields from
SessionVars
toMutateContext
. This PR added:WriteStmtBufs
forMutateBuffers
ConnectionID
forMutateContext
TxnAssertionLevel
forMutateContext
EnableMutationChecker
forMutateContext
Check List
Tests
Side effects
Documentation
Release note
Please refer to Release Notes Language Style Guide to write a quality release note.