Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

planner: Select-For-Update should skip the FastPlan #54773

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

planner: Select-For-Update should skip the FastPlan #54773

wants to merge 3 commits into from
+14 −4

Conversation

hawkingrei
Copy link
Member

@hawkingrei hawkingrei commented Jul 19, 2024 •
edited
Loading

What problem does this PR solve?

Issue Number: close #54705

Problem Summary:

What changed and how does it work?

select ... for update should skip the FastPlan.

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No need to test
    • I checked and no code files have been changed.

Side effects

  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Breaking backward compatibility

Documentation

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Changes MySQL compatibility

Release note

Please refer to Release Notes Language Style Guide to write a quality release note.

None

@hawkingrei
planner: Select-For-Update should skip the FastPlan
e2676d3 
Signed-off-by: Weizhen Wang <wangweizhen@pingcap.com>
@ti-chi-bot ti-chi-bot bot added do-not-merge/needs-linked-issue do-not-merge/needs-tests-checked release-note-none Denotes a PR that doesn't merit a release note. sig/planner SIG: Planner size/S Denotes a PR that changes 10-29 lines, ignoring generated files. and removed do-not-merge/needs-linked-issue do-not-merge/needs-tests-checked labels Jul 19, 2024
@ti-chi-bot ti-chi-bot bot added approved needs-1-more-lgtm Indicates a PR needs 1 more LGTM. labels Jul 19, 2024
@ti-chi-bot ti-chi-bot
Copy link

ti-chi-bot bot commented Jul 19, 2024

[LGTM Timeline notifier]

Timeline:

  • 2024-07-19 09:42:14.096989164 +0000 UTC m=+606156.087930634: ☑️ agreed by AilinKid.

@hawkingrei
update
ae6b9a2 
Signed-off-by: Weizhen Wang <wangweizhen@pingcap.com>
@ti-chi-bot ti-chi-bot
Copy link

ti-chi-bot bot commented Jul 19, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: AilinKid

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@codecov Codecov
Copy link

codecov bot commented Jul 19, 2024 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 55.6828%. Comparing base (fc47338) to head (2f462d8).
Report is 845 commits behind head on master.

Additional details and impacted files 
@@                Coverage Diff                @@
##             master     #54773         +/-   ##
=================================================
- Coverage   72.8103%   55.6828%   -17.1275%     
=================================================
  Files          1553       1676        +123     
  Lines        437420     610601     +173181     
=================================================
+ Hits         318487     340000      +21513     
- Misses        99331     247258     +147927     
- Partials      19602      23343       +3741
Flag Coverage Δ
integration 23.0166% <100.0000%> (?)
unit 71.7098% <100.0000%> (-0.1363%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
dumpling 52.9656% <ø> (ø)
parser ∅ <ø> (∅)
br 52.5929% <ø> (+6.7316%) ⬆️

@hawkingrei
update
2f462d8 
Signed-off-by: Weizhen Wang <wangweizhen@pingcap.com>
@ti-chi-bot ti-chi-bot
Copy link

ti-chi-bot bot commented Jul 19, 2024

@hawkingrei: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
idc-jenkins-ci-tidb/check_dev 2f462d8 link true /test check-dev
idc-jenkins-ci-tidb/check_dev_2 2f462d8 link true /test check-dev2

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

cfzjywxk
cfzjywxk reviewed Jul 19, 2024
View reviewed changes
pkg/planner/core/point_get_plan.go
@@ -883,7 +883,7 @@ func TryFastPlan(ctx base.PlanContext, node ast.Node) (p base.Plan) {
ctx.GetSessionVars().PlanColumnID.Store(0)
switch x := node.(type) {
case *ast.SelectStmt:
if x.SelectIntoOpt != nil {
if x.SelectIntoOpt != nil || x.LockInfo != nil {
Copy link
Contributor

@cfzjywxk cfzjywxk Jul 19, 2024 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The lock operations of point get and batch point get are push down. The original design of selectLockExec was only for cop reads that cannot be pushed down.

TryFastPlan is designed be used to generate point/batch point get plans with for update.

The issue is not a high priority one by now, better to resolve the plan display issue after some proper executor builder and transaction state refactor.

Copy link
Contributor

@AilinKid AilinKid Jul 24, 2024 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

so it's barely a explained issue, not the correctness one, right? 😂

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes the correctness one is #54652.
The severity of #54705 is moderate, there is also related behaviour fix checking lock is needed or not in https://github.com/pingcap/tidb/pull/54738/files#diff-359d434f5527f2d2157554bb9081bdc497f25e0a76253907fb5c9d1bdfb9b233L770.

@ti-chi-bot ti-chi-bot added needs-cherry-pick-release-6.5 Should cherry pick this PR to release-6.5 branch. needs-cherry-pick-release-7.5 Should cherry pick this PR to release-7.5 branch. needs-cherry-pick-release-8.1 Should cherry pick this PR to release-8.1 branch. needs-cherry-pick-release-7.1 Should cherry pick this PR to release-7.1 branch. labels Jul 26, 2024
@ti-chi-bot ti-chi-bot
Copy link

ti-chi-bot bot commented Nov 8, 2024

PR needs rebase.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@ti-chi-bot ti-chi-bot bot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Nov 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@AilinKid AilinKid AilinKid approved these changes

@cfzjywxk cfzjywxk cfzjywxk left review comments

Assignees
No one assigned
Labels
approved needs-1-more-lgtm Indicates a PR needs 1 more LGTM. needs-cherry-pick-release-6.5 Should cherry pick this PR to release-6.5 branch. needs-cherry-pick-release-7.1 Should cherry pick this PR to release-7.1 branch. needs-cherry-pick-release-7.5 Should cherry pick this PR to release-7.5 branch. needs-cherry-pick-release-8.1 Should cherry pick this PR to release-8.1 branch. needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. release-note-none Denotes a PR that doesn't merit a release note. sig/planner SIG: Planner size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

txn: incompatbile lock behaviour for cop and point get for update read
4 participants
@hawkingrei @cfzjywxk @AilinKid @ti-chi-bot