-
Notifications
You must be signed in to change notification settings - Fork 5.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
table: Add GetStatisticsSupport
and GetBinlogSupport
for MutateContext
#54832
Conversation
Hi @lcwangchao. Thanks for your PR. PRs from untrusted users cannot be marked as trusted with I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #54832 +/- ##
=================================================
- Coverage 74.7207% 56.6394% -18.0813%
=================================================
Files 1557 1674 +117
Lines 363500 613272 +249772
=================================================
+ Hits 271610 347354 +75744
- Misses 72240 242382 +170142
- Partials 19650 23536 +3886
Flags with carried forward coverage won't be shown. Click here to find out more.
|
e385af2
to
cfb89de
Compare
/retest |
@lcwangchao: Cannot trigger testing until a trusted user reviews the PR and leaves an In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
/retest |
@lcwangchao: Cannot trigger testing until a trusted user reviews the PR and leaves an In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: tangenta, YangKeao The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
What problem does this PR solve?
Issue Number: ref #54397
Some fields/operations provided by
MutateContext
are optional. For example, binlog is not used in lighting import and all binlog operations should be skipped in this scene.To make the
MutateContext
easy to construct and better decouple withsessionctx.Context
. We can add some "optional" design for some fields or methods.What changed and how does it work?
We name some operational information with "XXXSupport" and provide methods "GetXXXSupport" to return them. These methods return two values, the first value is the optional object implements
XXXSupport
and the second value is a boolean that indicates whether it is supported.In this PR, two optional objects are defined to support binlog and statistics update:
The
MutateContext
also provides methods to get them:Check List
Tests
Side effects
Documentation
Release note
Please refer to Release Notes Language Style Guide to write a quality release note.