Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

planner: move logical show ddl jobs to logicalop pkg. #54930

Merged
merged 3 commits into from
Jul 29, 2024

Conversation

AilinKid
Copy link
Contributor

What problem does this PR solve?

Issue Number: ref #51664, ref #52714

Problem Summary:

What changed and how does it work?

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No need to test
    • I checked and no code files have been changed.

Side effects

  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Breaking backward compatibility

Documentation

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Changes MySQL compatibility

Release note

Please refer to Release Notes Language Style Guide to write a quality release note.

None

@ti-chi-bot ti-chi-bot bot added release-note-none Denotes a PR that doesn't merit a release note. sig/planner SIG: Planner size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Jul 26, 2024
Copy link

tiprow bot commented Jul 26, 2024

Hi @AilinKid. Thanks for your PR.

PRs from untrusted users cannot be marked as trusted with /ok-to-test in this repo meaning untrusted PR authors can never trigger tests themselves. Collaborators can still trigger tests on the PR using /test all.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

Copy link

codecov bot commented Jul 26, 2024

Codecov Report

Attention: Patch coverage is 93.75000% with 1 line in your changes missing coverage. Please review.

Project coverage is 74.6978%. Comparing base (7cdf918) to head (b77e1aa).
Report is 5 commits behind head on master.

Current head b77e1aa differs from pull request most recent head b579c16

Please upload reports for the commit b579c16 to get more accurate results.

Additional details and impacted files
@@               Coverage Diff                @@
##             master     #54930        +/-   ##
================================================
+ Coverage   72.8407%   74.6978%   +1.8571%     
================================================
  Files          1560       1561         +1     
  Lines        438616     438544        -72     
================================================
+ Hits         319491     327583      +8092     
+ Misses        99541      90818      -8723     
- Partials      19584      20143       +559     
Flag Coverage Δ
integration 49.5776% <93.7500%> (?)
unit 71.6909% <93.7500%> (-0.1532%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
dumpling 52.9567% <ø> (ø)
parser ∅ <ø> (∅)
br 52.5289% <ø> (+6.6498%) ⬆️

@AilinKid AilinKid force-pushed the move-logical-show-ddl-jobs branch from 16626b9 to b77e1aa Compare July 26, 2024 08:20
@ti-chi-bot ti-chi-bot bot added approved needs-1-more-lgtm Indicates a PR needs 1 more LGTM. labels Jul 26, 2024
Copy link

ti-chi-bot bot commented Jul 26, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: hawkingrei, qw4990

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot bot added lgtm and removed needs-1-more-lgtm Indicates a PR needs 1 more LGTM. labels Jul 26, 2024
Copy link

ti-chi-bot bot commented Jul 26, 2024

[LGTM Timeline notifier]

Timeline:

  • 2024-07-26 09:35:41.673253309 +0000 UTC m=+1210563.664194779: ☑️ agreed by hawkingrei.
  • 2024-07-26 09:36:14.28386831 +0000 UTC m=+1210596.274809778: ☑️ agreed by qw4990.

@ti-chi-bot ti-chi-bot bot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Jul 26, 2024
AilinKid added 2 commits July 29, 2024 14:16
.
Signed-off-by: AilinKid <314806019@qq.com>
.
Signed-off-by: AilinKid <314806019@qq.com>
@AilinKid AilinKid force-pushed the move-logical-show-ddl-jobs branch from b77e1aa to bcbaa99 Compare July 29, 2024 06:16
@ti-chi-bot ti-chi-bot bot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Jul 29, 2024
.
Signed-off-by: AilinKid <314806019@qq.com>
@AilinKid
Copy link
Contributor Author

/retest-required

Copy link

tiprow bot commented Jul 29, 2024

@AilinKid: Cannot trigger testing until a trusted user reviews the PR and leaves an /ok-to-test message.

In response to this:

/retest-required

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@ti-chi-bot ti-chi-bot bot merged commit 9bda5d2 into pingcap:master Jul 29, 2024
10 checks passed
hawkingrei pushed a commit to hawkingrei/tidb that referenced this pull request Aug 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved lgtm release-note-none Denotes a PR that doesn't merit a release note. sig/planner SIG: Planner size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants