planner: Add Revision check in tryLockMDLAndUpdateSchemaIfNecessary

[joechenrh]

What problem does this PR solve?

Issue Number: close #54779

What changed and how does it work?

Before checking table change by comparing TableInfo, we can just examine Revision first to skip unnecessary checks. Besides, I also found that column comparation is done by double loop, which can use map.

tidb/pkg/planner/core/preprocess.go

Lines 1874 to 1875 in da7d83f

	// Check the table change, if adding new public index or modify a column, we need to handle them.
	if !sctx.GetSessionVars().IsPessimisticReadConsistency() {

Using a table containing more than 1000 columns to test.

Before:

After:

Check List

Tests

• Unit test
• Integration test
• Manual test (add detailed scripts or steps below)
• No need to test

  • I checked and no code files have been changed.

Side effects

• Performance regression: Consumes more CPU
• Performance regression: Consumes more Memory
• Breaking backward compatibility

Documentation

• Affects user behaviors
• Contains syntax changes
• Contains variable changes
• Contains experimental features
• Changes MySQL compatibility

Release note

Please refer to Release Notes Language Style Guide to write a quality release note.

None

[ti-chi-bot]

Hi @joechenrh. Thanks for your PR.

I'm waiting for a pingcap member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[tiprow]

Hi @joechenrh. Thanks for your PR.

PRs from untrusted users cannot be marked as trusted with /ok-to-test in this repo meaning untrusted PR authors can never trigger tests themselves. Collaborators can still trigger tests on the PR using /test all.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

[lcwangchao]

A indexID to indexName mapping with type map[int64]int64 maybe more efficient in map searching

[ti-chi-bot]

[LGTM Timeline notifier]

Timeline:

• 2024-07-29 06:45:52.699286586 +0000 UTC m=+165468.979334656: ☑️ agreed by wjhuang2016.
• 2024-07-29 07:08:53.518818338 +0000 UTC m=+166849.798866400: ☑️ agreed by lcwangchao.

[codecov]

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 76.8175%. Comparing base (e0e8f89) to head (ab606c1).
Report is 58 commits behind head on master.

Additional details and impacted files

@@               Coverage Diff                @@
##             master     #54963        +/-   ##
================================================
+ Coverage   72.6985%   76.8175%   +4.1190%     
================================================
  Files          1560       1575        +15     
  Lines        438485     455827     +17342     
================================================
+ Hits         318772     350155     +31383     
+ Misses       100049      85313     -14736     
- Partials      19664      20359       +695     

Flag	Coverage Δ
integration	52.6315% <64.7058%> (?)
unit	73.1848% <100.0000%> (+1.4964%)	⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Components	Coverage Δ
dumpling	52.9567% <ø> (ø)
parser	∅ <ø> (∅)
br	62.7873% <ø> (+16.8830%)	⬆️

[lance6716]

/assign @qw4990

[ti-chi-bot]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: lcwangchao, qw4990, wjhuang2016

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• pkg/planner/OWNERS [qw4990]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[qw4990]

Do we need to back port this to v8.1 or v7.5?

[wjhuang2016]

/retest

[wjhuang2016]

/retest

[joechenrh]

/retest

[ti-chi-bot]

@joechenrh: Cannot trigger testing until a trusted user reviews the PR and leaves an /ok-to-test message.

In response to this:

/retest

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[tiprow]

@joechenrh: Cannot trigger testing until a trusted user reviews the PR and leaves an /ok-to-test message.

In response to this:

/retest

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

[lance6716]

/retest

[tiprow]

@lance6716: Cannot trigger testing until a trusted user reviews the PR and leaves an /ok-to-test message.

In response to this:

/retest

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

[lance6716]

/retest

[tiprow]

@lance6716: Cannot trigger testing until a trusted user reviews the PR and leaves an /ok-to-test message.

In response to this:

/retest

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

[Benjamin2037]

/ok-to-test

[joechenrh]

/retest-required

[tiprow]

@joechenrh: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name	Commit	Details	Required	Rerun command
fast_test_tiprow	ab606c1	link	true	/test fast_test_tiprow

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.