expression: fix infinity loop in timestampadd | tidb-test=pr/2378

[ti-chi-bot]

This is an automated cherry-pick of #54916

What problem does this PR solve?

Issue Number: close #54908

Problem Summary:

What changed and how does it work?

Check List

Tests

• Unit test
• Integration test
• Manual test (add detailed scripts or steps below)
• No need to test

  • I checked and no code files have been changed.

Side effects

• Performance regression: Consumes more CPU
• Performance regression: Consumes more Memory
• Breaking backward compatibility

Documentation

• Affects user behaviors
• Contains syntax changes
• Contains variable changes
• Contains experimental features
• Changes MySQL compatibility

Release note

Please refer to Release Notes Language Style Guide to write a quality release note.

Fix the issue that `timestampadd` function enters into infinity loop when the first parameter is 'month' and the second parameter is a negative number.

[codecov]

Codecov Report

All modified and coverable lines are covered by tests ✅

Please upload report for BASE (release-7.1@d97c194). Learn more about missing BASE report.

Additional details and impacted files

@@               Coverage Diff                @@
##             release-7.1     #54971   +/-   ##
================================================
  Coverage               ?   73.4569%           
================================================
  Files                  ?       1211           
  Lines                  ?     380337           
  Branches               ?          0           
================================================
  Hits                   ?     279384           
  Misses                 ?      83115           
  Partials               ?      17838           

[xzhangxian1008]

/cc @windtalker

[xzhangxian1008]

/retest

[windtalker]

lgtm

[ti-chi-bot]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: windtalker, XuHuaiyu

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS [XuHuaiyu,windtalker]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[ti-chi-bot]

[LGTM Timeline notifier]

Timeline:

• 2024-07-29 03:54:14.869095969 +0000 UTC m=+155171.149144037: ☑️ agreed by XuHuaiyu.
• 2024-07-31 08:21:41.688454568 +0000 UTC m=+344017.968502638: ☑️ agreed by windtalker.

[xzhangxian1008]

/retitle expression: fix infinity loop in timestampadd | tidb-test=pr/2378

[xzhangxian1008]

/retest