-
Notifications
You must be signed in to change notification settings - Fork 5.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ddl: Regenerating AutoIDs for _tidb_rowid during Reorganize Partition (#53770) #55052
base: release-8.1
Are you sure you want to change the base?
ddl: Regenerating AutoIDs for _tidb_rowid during Reorganize Partition (#53770) #55052
Conversation
Signed-off-by: ti-chi-bot <ti-community-prow-bot@tidb.io>
This cherry pick PR is for a release branch and has not yet been approved by triage owners. To merge this cherry pick:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: mjonss The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
[LGTM Timeline notifier]Timeline:
|
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## release-8.1 #55052 +/- ##
================================================
Coverage ? 71.1581%
================================================
Files ? 1466
Lines ? 422643
Branches ? 0
================================================
Hits ? 300745
Misses ? 101388
Partials ? 20510
Flags with carried forward coverage won't be shown. Click here to find out more.
|
This is an automated cherry-pick of #53770
What problem does this PR solve?
When EXCHANGE PARTITION is used, the _tidb_rowid from the exchanged table, may conflict with rows in other partitions, which can collide during REORGANIZE PARTITION or REMOVE PARTITIONING since they keep the _tidb_rowid but will be placed in the same physical partition/table.
Solution:
Generate new _tidb_rowid for each row during the data reorganization phase.
Issue Number: close #53385
Problem Summary:
What changed and how does it work?
Check List
Tests
Side effects
Documentation
Release note
Please refer to Release Notes Language Style Guide to write a quality release note.