*: kill auto analyze out of the auto analyze time windows #55062
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ti-chi-bot
bot
added
release-note-none
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #55062 +/- ##
================================================
+ Coverage 74.8131% 75.8495% +1.0363%
================================================
Files 1570 1570
Lines 364718 442459 +77741
================================================
+ Hits 272857 335603 +62746
- Misses 72124 86326 +14202
- Partials 19737 20530 +793
Flags with carried forward coverage won't be shown. Click here to find out more.
|
hawkingrei
force-pushed
the
kill_running_analyze_out_auto_analyze_windows
branch
from
24829b5 to
0f28403
Compare
ti-chi-bot
bot
added
size/L
|
/retest |
hawkingrei
changed the title
hawkingrei
commented
Aug 8, 2024
| @@ -72,7 +72,8 @@ func AutoAnalyze( | |||
| } | |||
| } | |||
|
|
|||
| func execAnalyzeStmt( | |||
| // RunAnalyzeStmt executes the analyze statement. | |||
| func RunAnalyzeStmt( | |||
There was a problem hiding this comment.
Be public for test and exec.ExecXXXX is not acceptable for linter.
hawkingrei
force-pushed
the
kill_running_analyze_out_auto_analyze_windows
branch
2 times, most recently
from
b00a564 to
933eb32
Compare
ti-chi-bot
bot
added
size/XXL
hawkingrei
force-pushed
the
kill_running_analyze_out_auto_analyze_windows
branch
from
933eb32 to
2fa9885
Compare
ti-chi-bot
bot
added
size/L
Signed-off-by: Weizhen Wang <wangweizhen@pingcap.com>
hawkingrei
force-pushed
the
kill_running_analyze_out_auto_analyze_windows
branch
from
2fa9885 to
578e779
Compare
|
/retest |
qw4990
approved these changes
Aug 8, 2024
winoros
approved these changes
Aug 9, 2024
ti-chi-bot
bot
added
lgtm
and removed
needs-1-more-lgtm
lance6716
approved these changes
Aug 9, 2024
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: lance6716, qw4990, winoros The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
ti-chi-bot
added
the
needs-cherry-pick-release-8.1
|
In response to a cherrypick label: new pull request created to branch |
ti-chi-bot
pushed a commit
to ti-chi-bot/tidb
that referenced
this pull request
Aug 20, 2024
Signed-off-by: ti-chi-bot <ti-community-prow-bot@tidb.io>
13 tasks
ti-chi-bot
added
needs-cherry-pick-release-7.5
ti-chi-bot
pushed a commit
to ti-chi-bot/tidb
that referenced
this pull request
Aug 20, 2024
Signed-off-by: ti-chi-bot <ti-community-prow-bot@tidb.io>
13 tasks
|
In response to a cherrypick label: new pull request created to branch |
ti-chi-bot
bot
added
the
needs-cherry-pick-release-6.5
ti-chi-bot
pushed a commit
to ti-chi-bot/tidb
that referenced
this pull request
Sep 6, 2024
Signed-off-by: ti-chi-bot <ti-community-prow-bot@tidb.io>
13 tasks
|
In response to a cherrypick label: new pull request created to branch |
ti-chi-bot
bot
removed
the
needs-cherry-pick-release-6.5
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What problem does this PR solve?
Issue Number: close #55283
Problem Summary:
What changed and how does it work?
TiDB forget to kill the anto analyze which is out of the time windows
Check List
Tests
Side effects
Documentation
Release note
Please refer to Release Notes Language Style Guide to write a quality release note.