Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ddl: record get owner TS and compare it before runReorgJob quit (#55049) #55076

Closed

Conversation

tangenta
Copy link
Contributor

Cherry-pick #55049

What problem does this PR solve?

Issue Number: close #54897

Problem Summary:

Timeline:

  1. tidb-0 run ingest backfill workers as the DDL owner.
  2. Inject network latency to tidb-0.
  3. tidb-1 get DDL owner, and switch to merge temp index step.
  4. Inject network latency to tidb-1. tidb-1's merge temp index backfill workers failed with "DDL is not owner"
  5. tidb-0 get DDL owner AGAIN, but reorgCtx is the one added in step(1).
  6. Merge temp index step is skipped because the reorgCtx is done.

What changed and how does it work?

Record get owner TS and compare it before runReorgJob quit.

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No need to test
    • I checked and no code files have been changed.

Side effects

  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Breaking backward compatibility

Documentation

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Changes MySQL compatibility

Release note

Please refer to Release Notes Language Style Guide to write a quality release note.

None

Sorry, something went wrong.

@ti-chi-bot ti-chi-bot bot added release-note-none Denotes a PR that doesn't merit a release note. do-not-merge/cherry-pick-not-approved labels Jul 30, 2024
@ti-chi-bot ti-chi-bot added the cherry-pick-approved Cherry pick PR approved by release team. label Jul 30, 2024
Copy link

ti-chi-bot bot commented Jul 30, 2024

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please ask for approval from tangenta, ensuring that each of them provides their approval before proceeding. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot bot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Jul 30, 2024
Copy link

tiprow bot commented Jul 30, 2024

Hi @tangenta. Thanks for your PR.

PRs from untrusted users cannot be marked as trusted with /ok-to-test in this repo meaning untrusted PR authors can never trigger tests themselves. Collaborators can still trigger tests on the PR using /test all.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

Copy link

codecov bot commented Jul 30, 2024

Codecov Report

Attention: Patch coverage is 70.83333% with 7 lines in your changes missing coverage. Please review.

Please upload report for BASE (release-7.5@6990c1f). Learn more about missing BASE report.

Additional details and impacted files
@@               Coverage Diff                @@
##             release-7.5     #55076   +/-   ##
================================================
  Coverage               ?   71.9908%           
================================================
  Files                  ?       1413           
  Lines                  ?     411680           
  Branches               ?          0           
================================================
  Hits                   ?     296372           
  Misses                 ?      95411           
  Partials               ?      19897           
Flag Coverage Δ
unit 71.9908% <70.8333%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
dumpling 52.9400% <0.0000%> (?)
parser ∅ <0.0000%> (?)
br 53.5230% <0.0000%> (?)

@tangenta
Copy link
Contributor Author

Duplicated with #55111

@tangenta tangenta closed this Jul 31, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cherry-pick-approved Cherry pick PR approved by release team. release-note-none Denotes a PR that doesn't merit a release note. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants