Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

expression: fix infinity loop in timestampadd | tidb-test=release-6.5 plugin=release-6.5 #55143

Merged

Conversation

xzhangxian1008
Copy link
Contributor

What problem does this PR solve?

Issue Number: close #54908

Problem Summary:

What changed and how does it work?

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No need to test
    • I checked and no code files have been changed.

Side effects

  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Breaking backward compatibility

Documentation

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Changes MySQL compatibility

Release note

Please refer to Release Notes Language Style Guide to write a quality release note.

None

@ti-chi-bot ti-chi-bot bot added release-note-none Denotes a PR that doesn't merit a release note. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Aug 1, 2024
Copy link

tiprow bot commented Aug 1, 2024

Hi @xzhangxian1008. Thanks for your PR.

PRs from untrusted users cannot be marked as trusted with /ok-to-test in this repo meaning untrusted PR authors can never trigger tests themselves. Collaborators can still trigger tests on the PR using /test all.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@wuhuizuo
Copy link
Contributor

wuhuizuo commented Aug 2, 2024

/retitle expression: fix infinity loop in timestampadd | tidb-test=release-6.5 plugin=release-6.5

@ti-chi-bot ti-chi-bot bot changed the title expression: fix infinity loop in timestampadd | tidb-test=pr/2373 expression: fix infinity loop in timestampadd | tidb-test=release-6.5 plugin=release-6.5 Aug 2, 2024
@wuhuizuo
Copy link
Contributor

wuhuizuo commented Aug 2, 2024

/retest

Copy link

tiprow bot commented Aug 2, 2024

@wuhuizuo: Cannot trigger testing until a trusted user reviews the PR and leaves an /ok-to-test message.

In response to this:

/retest

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

Copy link

codecov bot commented Aug 2, 2024

Codecov Report

Attention: Patch coverage is 61.22449% with 19 lines in your changes missing coverage. Please review.

Please upload report for BASE (release-6.5-20240801-v6.5.10@ff2feb6). Learn more about missing BASE report.

Additional details and impacted files
@@                        Coverage Diff                        @@
##             release-6.5-20240801-v6.5.10     #55143   +/-   ##
=================================================================
  Coverage                                ?   73.6142%           
=================================================================
  Files                                   ?       1096           
  Lines                                   ?     352251           
  Branches                                ?          0           
=================================================================
  Hits                                    ?     259307           
  Misses                                  ?      76262           
  Partials                                ?      16682           

Copy link
Contributor

@windtalker windtalker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ti-chi-bot ti-chi-bot bot added needs-1-more-lgtm Indicates a PR needs 1 more LGTM. approved labels Aug 2, 2024
@XuHuaiyu
Copy link
Contributor

XuHuaiyu commented Aug 2, 2024

/ok-to-test

@ti-chi-bot ti-chi-bot bot added the ok-to-test Indicates a PR is ready to be tested. label Aug 2, 2024
Copy link

ti-chi-bot bot commented Aug 2, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: windtalker, XuHuaiyu

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [XuHuaiyu,windtalker]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot bot added lgtm and removed needs-1-more-lgtm Indicates a PR needs 1 more LGTM. labels Aug 2, 2024
Copy link

ti-chi-bot bot commented Aug 2, 2024

[LGTM Timeline notifier]

Timeline:

  • 2024-08-02 02:03:25.807463374 +0000 UTC m=+55003.026224974: ☑️ agreed by windtalker.
  • 2024-08-02 03:49:02.969031984 +0000 UTC m=+61340.187793593: ☑️ agreed by XuHuaiyu.

@ti-chi-bot ti-chi-bot bot merged commit b89e951 into pingcap:release-6.5-20240801-v6.5.10 Aug 2, 2024
10 checks passed
@xzhangxian1008 xzhangxian1008 deleted the cp-timestamp branch August 2, 2024 04:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved lgtm ok-to-test Indicates a PR is ready to be tested. release-note-none Denotes a PR that doesn't merit a release note. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants