planner/core: define extractor for each schema related memtables #55144

tangenta · 2024-08-01T14:05:18Z

What problem does this PR solve?

Issue Number: ref #50305

Problem Summary:

What changed and how does it work?

Add extractor for infoschema.TableSchemata and infoschema.TableStatistics.
Rename previous InfoSchemaTablesExtractor to InfoSchemaBaseExtractor, and embed it into following extractors:
- InfoSchemaTablesExtractor
- InfoSchemaPartitionsExtractor
- InfoSchemaStatisticsExtractor
- InfoSchemaSchemataExtractor
Provide ListSchemas() and ListTables() for previous extractors.

Check List

Tests

Unit test
Integration test
Manual test (add detailed scripts or steps below)
No need to test
- I checked and no code files have been changed.

Side effects

Performance regression: Consumes more CPU
Performance regression: Consumes more Memory
Breaking backward compatibility

Documentation

Release note

Please refer to Release Notes Language Style Guide to write a quality release note.

None

tiprow · 2024-08-01T14:05:39Z

Hi @tangenta. Thanks for your PR.

PRs from untrusted users cannot be marked as trusted with /ok-to-test in this repo meaning untrusted PR authors can never trigger tests themselves. Collaborators can still trigger tests on the PR using /test all.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

codecov · 2024-08-01T14:39:57Z

Codecov Report

Attention: Patch coverage is 77.09751% with 101 lines in your changes missing coverage. Please review.

Project coverage is 73.4966%. Comparing base (5aad7df) to head (58cabe9).
Report is 2 commits behind head on master.

Additional details and impacted files

@@               Coverage Diff                @@
##             master     #55144        +/-   ##
================================================
+ Coverage   72.8978%   73.4966%   +0.5987%     
================================================
  Files          1569       1570         +1     
  Lines        439212     440242      +1030     
================================================
+ Hits         320176     323563      +3387     
+ Misses        99399      96693      -2706     
- Partials      19637      19986       +349

Flag	Coverage Δ
integration	`22.5040% <21.7687%> (?)`

Flags with carried forward coverage won't be shown. Click here to find out more.

Components	Coverage Δ
dumpling	`52.9567% <ø> (ø)`
parser	`∅ <ø> (∅)`
br	`46.1692% <ø> (+0.2670%)`	⬆️

lance6716

2 / 7 files viewed

pkg/planner/core/memtable_infoschema_extractor.go

wjhuang2016 · 2024-08-02T08:16:36Z

pkg/executor/infoschema_reader.go

-			continue
-		}
-		tables, err := e.is.SchemaTableInfos(ctx, schema)
+		tables, err := ex.ListTables(ctx, e.is, schema)


Why ListTables?

here List... does not mean full scan tables. It will filter with ex's predicates. Maybe rename it?

Do you have any suggestions for naming?

It is actually "list part of tables if predicate exists, otherwise list all tables".

How about FilterSchemas FilterTables ?

Do you mean FilteredSchema and FilteredTables?

lance6716

5 / 7 files viewed

pkg/executor/infoschema_reader.go

pkg/planner/core/memtable_infoschema_extractor.go

wjhuang2016 · 2024-08-02T08:30:58Z

pkg/planner/core/memtable_infoschema_extractor.go

+		if !ok {
+			continue
+		}
+		_, err := is.TableByName(ctx, schema, tbl.Meta().Name)


Why checking the name here?

tiancaiamao · 2024-08-02T08:54:40Z

pkg/executor/infoschema_reader.go

-		return
+	ex, ok := e.extractor.(*plannercore.InfoSchemaSchemataExtractor)
+	if !ok {
+		return errors.Errorf("wrong extractor type: %T, expected InfoSchemaSchemataExtractor", e.extractor)


Do we have tests to cover such case? If no, if plannercore change it, there is no way to found.

tiancaiamao · 2024-08-02T08:59:03Z

pkg/executor/infoschema_reader.go

-			continue
-		}
-		tables, err := e.is.SchemaTableInfos(ctx, schema)
+		tables, err := ex.ListTables(ctx, e.is, schema)


How about FilterSchemas FilterTables ?

ti-chi-bot · 2024-08-05T08:11:23Z

[LGTM Timeline notifier]

Timeline:

2024-08-02 10:31:05.25556504 +0000 UTC m=+2395.122664139: ☑️ agreed by tiancaiamao.
2024-08-05 08:11:22.734339757 +0000 UTC m=+253212.601438837: ☑️ agreed by wjhuang2016.

tiprow · 2024-08-05T08:15:59Z

@tangenta: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name	Commit	Details	Required	Rerun command
fast_test_tiprow	`42198b3`	link	true	`/test fast_test_tiprow`

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

lance6716 · 2024-08-05T10:33:13Z

pkg/planner/core/memtable_infoschema_extractor.go

+	}
+	r := new(bytes.Buffer)
+	colNames := make([]string, 0, len(e.ColPredicates))
+	for colName := range e.ColPredicates {


maps.Keys()

lance6716 · 2024-08-05T10:36:17Z

pkg/planner/core/memtable_infoschema_extractor.go

+}
+
+// ExplainInfo implements base.MemTablePredicateExtractor interface.
+func (e *InfoSchemaBaseExtractor) ExplainInfo(_ base.PhysicalPlan) string {


I'm not sure what's the expected behaviour of ExplainInfo because the comments are poor. Should it be the used filter for a query rather than all filters?

Yes. For unused filters, they will be displayed as another operator. For example:

mysql> explain select * from information_schema.tables where (table_name = 't2' and tidb_table_id = 3); +----------------+----------+------+---------------+----------------------------------------+ | id | estRows | task | access object | operator info | +----------------+----------+------+---------------+----------------------------------------+ | MemTableScan_5 | 10000.00 | root | table:TABLES | table_name:["t2"], tidb_table_id:["3"] | +----------------+----------+------+---------------+----------------------------------------+ 1 row in set (0.00 sec) mysql> explain select * from information_schema.tables where table_name = 't1' or (table_name = 't2' and tidb_table_id = 3); +----------------------+----------+------+---------------+-------------------------------------------------------------------+ | id | estRows | task | access object | operator info | +----------------------+----------+------+---------------+-------------------------------------------------------------------+ | Selection_5 | 8000.00 | root | | or(eq(Column#3, "t1"), and(eq(Column#3, "t2"), eq(Column#22, 3))) | | └─MemTableScan_6 | 10000.00 | root | table:TABLES | | +----------------------+----------+------+---------------+-------------------------------------------------------------------+ 2 rows in set (0.00 sec)

lance6716

it's OK to merge this PR and fix my comments in future.

lance6716 · 2024-08-05T10:43:06Z

pkg/planner/core/memtable_infoschema_extractor.go

+		if !ok {
+			continue
+		}
+		if len(tableNames) > 0 && containInTableNames(tableNames, tbl) {


maybe use map type for tableNames, to implement O(1) containInTableNames.

lance6716 · 2024-08-05T10:48:17Z

pkg/planner/core/memtable_infoschema_extractor.go

+	tableMap := make(map[int64]schemaAndTable, len(tableNames))
+	for _, n := range tableNames {
+		for _, s := range schemas {
+			tbl, err := is.TableByName(ctx, s, n)


I see at least in infoschema v2 when we get the table we already know its db (tableItem has associated all related information together). So there's a potential optimization to skip the TableByName.

Maybe we can add more methods for infoschema v2 later.

ti-chi-bot · 2024-08-06T03:27:17Z

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: AilinKid, tiancaiamao, wjhuang2016

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

~~OWNERS~~ [AilinKid,tiancaiamao,wjhuang2016]
~~pkg/planner/OWNERS~~ [AilinKid]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

planner/core: define extractor for each schema related memtables

d56024e

ti-chi-bot bot added do-not-merge/needs-linked-issue do-not-merge/needs-tests-checked release-note-none Denotes a PR that doesn't merit a release note. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. sig/planner SIG: Planner labels Aug 1, 2024

ti-chi-bot bot removed do-not-merge/needs-linked-issue do-not-merge/needs-tests-checked labels Aug 1, 2024

tangenta added 6 commits August 1, 2024 22:55

update bazel

c3348f6

fix linter

f7fcfc6

fix linter

2992fdf

fix TestInfoSchemaTableExtract

7d57f8b

fix schemata order

a8bb4af

fix naming

3259ba5

lance6716 reviewed Aug 2, 2024

View reviewed changes

pkg/planner/core/memtable_infoschema_extractor.go Outdated Show resolved Hide resolved

pkg/planner/core/memtable_infoschema_extractor.go Show resolved Hide resolved

pkg/planner/core/memtable_infoschema_extractor.go Outdated Show resolved Hide resolved

wjhuang2016 reviewed Aug 2, 2024

View reviewed changes

lance6716 reviewed Aug 2, 2024

View reviewed changes

pkg/executor/infoschema_reader.go Outdated Show resolved Hide resolved

pkg/planner/core/memtable_infoschema_extractor.go Outdated Show resolved Hide resolved

wjhuang2016 reviewed Aug 2, 2024

View reviewed changes

tangenta added 4 commits August 2, 2024 16:37

rename global constants

3f70876

add comment for InfoschemaBaseExtractor.Filter()

ae8b47d

remove unnecessary ok

7040598

remove unnecessary filtering

45c56e1

tiancaiamao reviewed Aug 2, 2024

View reviewed changes

tiancaiamao approved these changes Aug 2, 2024

View reviewed changes

ti-chi-bot bot added needs-1-more-lgtm Indicates a PR needs 1 more LGTM. needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. labels Aug 2, 2024

tangenta added 2 commits August 3, 2024 15:21

find table info by id first

675c591

fix build

2073f41

Merge remote-tracking branch 'upstream/master' into HEAD

1d04d3f

ti-chi-bot bot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Aug 3, 2024

fix linter

42198b3

wjhuang2016 approved these changes Aug 5, 2024

View reviewed changes

ti-chi-bot bot added lgtm and removed needs-1-more-lgtm Indicates a PR needs 1 more LGTM. labels Aug 5, 2024

tangenta added 2 commits August 5, 2024 16:37

fix linter

4261a40

add test for information_schema.statistic and schemata

d8f19c6

lance6716 reviewed Aug 5, 2024

View reviewed changes

tangenta added 2 commits August 5, 2024 20:31

Merge remote-tracking branch 'upstream/master' into HEAD

8a540d6

address comments

05c4815

tangenta force-pushed the infoschema-extractor branch from 2b70976 to 05c4815 Compare August 5, 2024 12:45

tangenta added 2 commits August 6, 2024 01:51

test: drop unused db

5e51743

test: clean db after used

58cabe9

AilinKid approved these changes Aug 6, 2024

View reviewed changes

ti-chi-bot bot added the approved label Aug 6, 2024

ti-chi-bot bot merged commit 07c35e8 into pingcap:master Aug 6, 2024
20 of 21 checks passed

tangenta mentioned this pull request Aug 6, 2024

information_schema.tables return wrong result #55221

Closed

joechenrh mentioned this pull request Aug 7, 2024

*: update extractor for tidb_index_usage and columns table #55263

Merged

13 tasks

tangenta mentioned this pull request Aug 13, 2024

it takes nearly 10m to add an index with 200,000 schemas #55245

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

planner/core: define extractor for each schema related memtables #55144

planner/core: define extractor for each schema related memtables #55144

tangenta commented Aug 1, 2024 •

edited

Loading

tiprow bot commented Aug 1, 2024

codecov bot commented Aug 1, 2024 •

edited

Loading

lance6716 left a comment

wjhuang2016 Aug 2, 2024

lance6716 Aug 2, 2024

tangenta Aug 2, 2024

tiancaiamao Aug 2, 2024

tangenta Aug 5, 2024

lance6716 left a comment

wjhuang2016 Aug 2, 2024

tiancaiamao Aug 2, 2024

tangenta Aug 5, 2024

tiancaiamao Aug 2, 2024

ti-chi-bot bot commented Aug 5, 2024

tiprow bot commented Aug 5, 2024

lance6716 Aug 5, 2024

tangenta Aug 5, 2024

lance6716 Aug 5, 2024

tangenta Aug 5, 2024

lance6716 left a comment

lance6716 Aug 5, 2024

tangenta Aug 5, 2024

lance6716 Aug 5, 2024 •

edited

Loading

tangenta Aug 5, 2024

ti-chi-bot bot commented Aug 6, 2024

planner/core: define extractor for each schema related memtables #55144

planner/core: define extractor for each schema related memtables #55144

Conversation

tangenta commented Aug 1, 2024 • edited Loading

What problem does this PR solve?

What changed and how does it work?

Check List

Release note

tiprow bot commented Aug 1, 2024

codecov bot commented Aug 1, 2024 • edited Loading

Codecov Report

lance6716 left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

lance6716 left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

ti-chi-bot bot commented Aug 5, 2024

[LGTM Timeline notifier]

tiprow bot commented Aug 5, 2024

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

lance6716 left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

lance6716 Aug 5, 2024 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

ti-chi-bot bot commented Aug 6, 2024

tangenta commented Aug 1, 2024 •

edited

Loading

codecov bot commented Aug 1, 2024 •

edited

Loading

lance6716 Aug 5, 2024 •

edited

Loading